Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Yonghong Song ec874fb27f selftests/bpf: Fix flaky test btf_map_in_map/lookup_update ... [ Upstream commit 14bb1e8c8d ] Recently, I frequently hit the following test failure: [root@arch-fb-vm1 bpf]# ./test_progs -n 33/1 test_lookup_update:PASS:skel_open 0 nsec [...] test_lookup_update:PASS:sync_rcu 0 nsec test_lookup_update:FAIL:map1_leak inner_map1 leaked! #33/1 btf_map_in_map/lookup_update:FAIL #33 btf_map_in_map:FAIL In the test, after map is closed and then after two rcu grace periods, it is assumed that map_id is not available to user space. But the above assumption cannot be guaranteed. After zero or one or two rcu grace periods in different siturations, the actual freeing-map-work is put into a workqueue. Later on, when the work is dequeued, the map will be actually freed. See bpf_map_put() in kernel/bpf/syscall.c. By using workqueue, there is no ganrantee that map will be actually freed after a couple of rcu grace periods. This patch removed such map leak detection and then the test can pass consistently. Signed-off-by: Yonghong Song <yonghong.song@linux.dev> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20240322061353.632136-1-yonghong.song@linux.dev Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2024-07-05 09:14:25 +02:00
..
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest: force $buildonly = 1 for 'make_warnings_file' test type	2024-04-13 13:01:46 +02:00
kunit	kunit: tool: Import missing importlib.abc	2022-02-23 12:03:04 +01:00
nvdimm	memremap: remove support for external pgmap refcounts	2022-08-17 14:23:43 +02:00
radix-tree	radix tree test suite: fix incorrect allocation size for pthreads	2023-08-16 18:21:58 +02:00
scatterlist	Merge branch 'akpm' (patches from Andrew)	2021-09-03 10:08:28 -07:00
selftests	selftests/bpf: Fix flaky test btf_map_in_map/lookup_update	2024-07-05 09:14:25 +02:00
vsock	vsock_diag_test: remove free_sock_stat() call in test_no_sockets	2021-10-15 17:21:34 -07:00