linux/net/mptcp
Matthieu Baerts (NGI0) 50ee04e0ae mptcp: pm: ignore unknown endpoint flags
[ Upstream commit 0ace3297a7 ]

Before this patch, the kernel was saving any flags set by the userspace,
even unknown ones. This doesn't cause critical issues because the kernel
is only looking at specific ones. But on the other hand, endpoints dumps
could tell the userspace some recent flags seem to be supported on older
kernel versions.

Instead, ignore all unknown flags when parsing them. By doing that, the
userspace can continue to set unsupported flags, but it has a way to
verify what is supported by the kernel.

Note that it sounds better to continue accepting unsupported flags not
to change the behaviour, but also that eases things on the userspace
side by adding "optional" endpoint types only supported by newer kernel
versions without having to deal with the different kernel versions.

A note for the backports: there will be conflicts in mptcp.h on older
versions not having the mentioned flags, the new line should still be
added last, and the '5' needs to be adapted to have the same value as
the last entry.

Fixes: 01cacb00b3 ("mptcp: add netlink-based PM")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251205-net-mptcp-misc-fixes-6-19-rc1-v1-1-9e4781a6c1b8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ GENMASK(5, 0) => GENMASK(3, 0) + context ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2026-01-19 13:10:07 +01:00
..
crypto.c kunit: mptcp: adhere to KUNIT formatting standard 2021-04-16 17:10:40 -07:00
crypto_test.c mptcp: move crypto test to KUNIT 2020-06-26 16:21:39 -07:00
ctrl.c mptcp: faster active backup recovery 2021-08-14 11:37:25 +01:00
diag.c mptcp: correct MPTCP_SUBFLOW_ATTR_SSN_OFFSET reserved size 2024-09-04 13:23:19 +02:00
Kconfig kunit: mptcp: adhere to KUNIT formatting standard 2021-04-16 17:10:40 -07:00
Makefile kunit: mptcp: adhere to KUNIT formatting standard 2021-04-16 17:10:40 -07:00
mib.c mptcp: prevent MPC handshake on port-based signal endpoints 2024-10-22 15:40:47 +02:00
mib.h mptcp: prevent MPC handshake on port-based signal endpoints 2024-10-22 15:40:47 +02:00
mptcp_diag.c net: inet: Retire port only listening_hash 2023-11-28 16:56:22 +00:00
options.c mptcp: avoid unneeded subflow-level drops 2025-12-07 06:09:36 +09:00
pm.c mptcp: pm: in-kernel: usable client side with C-flag 2025-10-19 16:21:55 +02:00
pm_netlink.c mptcp: pm: ignore unknown endpoint flags 2026-01-19 13:10:07 +01:00
protocol.c mptcp: Fix proto fallback detection with BPF 2025-12-07 06:09:36 +09:00
protocol.h mptcp: avoid unneeded subflow-level drops 2025-12-07 06:09:36 +09:00
sockopt.c mptcp: sockopt: make sync_socket_options propagate SOCK_KEEPOPEN 2025-10-02 13:39:01 +02:00
subflow.c mptcp: Disallow MPTCP subflows from sockmap 2025-12-07 06:09:33 +09:00
syncookies.c mptcp: don't return sockets in foreign netns 2021-09-24 10:51:36 +01:00
token.c mptcp: don't return sockets in foreign netns 2021-09-24 10:51:36 +01:00
token_test.c mptcp: don't return sockets in foreign netns 2021-09-24 10:51:36 +01:00