kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-18 19:12:56 +00:00
Code Issues Releases Packages Activity
linux/drivers/infiniband/hw
History
Erez Shitrit 9bae3dbf72 IB/mlx4: Fix WQE LSO segment calculation 
commit ca9b590caa upstream.

The current code decreases from the mss size (which is the gso_size
from the kernel skb) the size of the packet headers.

It shouldn't do that because the mss that comes from the stack
(e.g IPoIB) includes only the tcp payload without the headers.

The result is indication to the HW that each packet that the HW sends
is smaller than what it could be, and too many packets will be sent
for big messages.

An easy way to demonstrate one more aspect of the problem is by
configuring the ipoib mtu to be less than 2*hlen (2*56) and then
run app sending big TCP messages. This will tell the HW to send packets
with giant (negative value which under unsigned arithmetics becomes
a huge positive one) length and the QP moves to SQE state.

Fixes: b832be1e40 ('IB/mlx4: Add IPoIB LSO support')
Reported-by: Matthew Finlay <matt@mellanox.com>
Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
History 2015-05-06 11:33:07 +01:00
..
amso1100 IB: Refactor umem to use linear SG table 2014-03-04 10:34:28 -08:00
cxgb3 RDMA/cxgb3: Remove a couple unneeded conditions 2014-05-28 10:04:00 -07:00
cxgb4 RDMA/cxgb4: Call iwpm_init() only once 2014-07-13 10:00:54 -07:00
ehca Merge branches 'core', 'cxgb4', 'ip-roce', 'iser', 'misc', 'mlx4', 'nes', 'ocrdma', 'qib', 'sgwrapper', 'srp' and 'usnic' into for-next 2014-04-03 08:30:17 -07:00
ipath IB/ipath: Use time_before()/_after() 2014-05-28 09:57:06 -07:00
mlx4 IB/mlx4: Fix WQE LSO segment calculation 2015-05-06 11:33:07 +01:00
mlx5 IB/mlx5: Enable "block multicast loopback" for kernel consumers 2014-07-16 23:14:26 -07:00
mthca IB/mthca: Use pci_enable_msix_exact() instead of pci_enable_msix() 2014-04-10 18:41:34 -07:00
nes RDMA/nes: Add support for iWARP Port Mapper user space service 2014-06-10 10:12:06 -07:00
ocrdma RDMA/ocrdma: Convert to use simple_open() 2014-05-19 17:55:54 -07:00
qib IB/qib: Do not write EEPROM 2015-03-02 15:04:28 +00:00
usnic Merge branches 'core', 'cxgb3', 'cxgb4', 'iser', 'iwpm', 'misc', 'mlx4', 'mlx5', 'noio', 'ocrdma', 'qib', 'srp' and 'usnic' into for-next 2014-06-10 10:12:14 -07:00
Makefile IB: Allow build of hw/ and ulp/ subdirectories independently 2014-06-02 14:51:12 -07:00