linux/drivers/usb
Alan Stern 425b3d713f USB: fix invalid memory access in hub_activate()
[ Upstream commit e50293ef97 ]

Commit 8520f38099 ("USB: change hub initialization sleeps to
delayed_work") changed the hub_activate() routine to make part of it
run in a workqueue.  However, the commit failed to take a reference to
the usb_hub structure or to lock the hub interface while doing so.  As
a result, if a hub is plugged in and quickly unplugged before the work
routine can run, the routine will try to access memory that has been
deallocated.  Or, if the hub is unplugged while the routine is
running, the memory may be deallocated while it is in active use.

This patch fixes the problem by taking a reference to the usb_hub at
the start of hub_activate() and releasing it at the end (when the work
is finished), and by locking the hub interface while the work routine
is running.  It also adds a check at the start of the routine to see
if the hub has already been disconnected, in which nothing should be
done.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Alexandru Cornea <alexandru.cornea@intel.com>
Tested-by: Alexandru Cornea <alexandru.cornea@intel.com>
Fixes: 8520f38099 ("USB: change hub initialization sleeps to delayed_work")
CC: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
History 2016-02-15 15:42:34 -05:00
..
atm usb: delete non-required instances of include <linux/init.h> 2014-01-08 15:01:39 -08:00
c67x00 USB: c67x00: correct spelling mistakes in comments 2014-01-08 15:05:14 -08:00
chipidea usb: chipidea: debug: add runtime pm for register access 2015-12-02 23:23:59 -05:00
class cdc-acm:exclude Samsung phone 04e8:685d 2016-02-15 15:42:29 -05:00
common usb: common: otg-fsm: only signal connect after switching to peripheral 2015-04-16 20:11:40 -04:00
core USB: fix invalid memory access in hub_activate() 2016-02-15 15:42:34 -05:00
dwc2 usb: dwc2: hcd: use new USB_RESUME_TIMEOUT 2015-06-28 13:39:22 -04:00
dwc3 usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes 2015-10-27 22:14:42 -04:00
early USB: ehci-dbgp: drop dead code. 2013-09-26 16:25:21 -07:00
gadget usb: gadget: pxa27x: fix suspend callback 2016-01-22 12:24:45 -05:00
host USB: whci-hcd: add check for dma mapping error 2016-01-22 12:24:45 -05:00
image USB: image: correct spelling mistake in comment 2014-01-08 15:08:14 -08:00
misc usb: rename phy to usb_phy in HCD 2014-09-29 11:52:59 -04:00
mon USB: regroup all depends on USB within an if USB block 2013-04-09 16:49:07 -07:00
musb usb: musb: USB_TI_CPPI41_DMA requires dmaengine support 2016-01-22 12:24:46 -05:00
phy usb: phy: Find the right match in devm_usb_phy_match 2015-05-17 19:11:58 -04:00
renesas_usbhs usb: renesas_usbhs: Don't disable the pipe if Control write status stage 2015-08-27 13:25:57 -04:00
serial USB: option: fix Cinterion AHxx enumeration 2016-02-15 15:42:31 -05:00
storage usb-storage: ignore ZTE MF 823 card reader in mode 0x1225 2015-08-27 13:25:47 -04:00
usbip usbip: remove struct usb_device_id table 2014-08-25 10:40:58 -07:00
wusbcore usb: hub: rename khubd to hub_wq in documentation and comments 2014-09-23 22:33:19 -07:00
Kconfig usb: Add LED triggers for USB activity 2014-09-25 17:05:12 +02:00
Makefile usbip: move usbip kernel code out of staging 2014-08-25 10:40:06 -07:00
README usb: hub: rename khubd to hub_wq in documentation and comments 2014-09-23 22:33:19 -07:00
usb-skeleton.c usb: delete non-required instances of include <linux/init.h> 2014-01-08 15:01:39 -08:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.