Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Andrii Nakryiko b955ceba2c selftests/bpf: fix test_spin_lock_fail.c's global vars usage ... [ Upstream commit 1b2bfc2969 ] Global variables of special types (like `struct bpf_spin_lock`) make underlying ARRAY maps non-mmapable. To make this work with libbpf's mmaping logic, application is expected to declare such special variables as static, so libbpf doesn't even attempt to mmap() such ARRAYs. test_spin_lock_fail.c didn't follow this rule, but given it relied on this test to trigger failures, this went unnoticed, as we never got to the step of mmap()'ing these ARRAY maps. It is fragile and relies on specific sequence of libbpf steps, which are an internal implementation details. Fix the test by marking lockA and lockB as static. Fixes: c48748aea4 ("selftests/bpf: Add failure test cases for spin lock pairing") Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/r/20241023043908.3834423-2-andrii@kernel.org Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2024-12-09 10:32:05 +01:00
..
crypto/chacha20-s390	tools/testing/crypto: Use vzalloc instead of vmalloc+memset	2022-07-05 14:46:36 +02:00
cxl	cxl/port: Fix use-after-free, permit out-of-order decoder shutdown	2024-11-08 16:28:24 +01:00
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest.pl: Avoid false positives with grub2 skip regex	2024-10-17 15:24:16 +02:00
kunit	kunit: tool: fix parsing of test attributes	2024-02-05 20:14:15 +00:00
memblock	memblock tests: fix warning ‘struct seq_file’ declared inside parameter list	2023-09-14 10:51:28 +03:00
nvdimm	tools/testing/nvdimm: Drop empty platform remove function	2023-06-07 13:30:21 -07:00
radix-tree	maple_tree: do not preallocate nodes for slot stores	2024-01-05 15:19:43 +01:00
scatterlist	tools/testing/scatterlist: add missing defines	2022-01-30 09:56:58 +02:00
selftests	selftests/bpf: fix test_spin_lock_fail.c's global vars usage	2024-12-09 10:32:05 +01:00
vsock	vsock/test: fix SEQPACKET message bounds test	2023-12-03 07:33:05 +01:00