Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Daniel Thompson ae72f1c1c2 param: fix crash on bad kernel arguments ... commit 3438cf549d upstream. Currently if the user passes an invalid value on the kernel command line then the kernel will crash during argument parsing. On most systems this is very hard to debug because the console hasn't been initialized yet. This is a regression due to commit 51e158c12a ("param: hand arguments after -- straight to init") which, in response to the systemd debug controversy, made it possible to explicitly pass arguments to init. To achieve this parse_args() was extended from simply returning an error code to returning a pointer. Regretably the new init args logic does not perform a proper validity check on the pointer resulting in a crash. This patch fixes the validity check. Should the check fail then no arguments will be passed to init. This is reasonable and matches how the kernel treats its own arguments (i.e. no error recovery). Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>		History 2014-11-27 11:21:42 +00:00
..
calibrate.c	kernel: delete __cpuinit usage from all core kernel files	2013-07-14 19:36:59 -04:00
do_mounts.c	init/do_mounts.c: fix comment error	2014-04-03 16:21:16 -07:00
do_mounts.h	md: move lots of #include lines out of .h files and into .c	2009-03-31 14:33:13 +11:00
do_mounts_initrd.c	usermodehelper: split remaining calls to call_usermodehelper_fns()	2013-04-30 17:04:06 -07:00
do_mounts_md.c	init: disable sparse checking of the mount.o source files	2012-05-31 17:49:27 -07:00
do_mounts_rd.c	cramfs: take headers to fs/cramfs	2014-01-25 03:13:02 -05:00
init_task.c	sched/rt: Move rt specific bits into new header file	2013-02-07 20:51:08 +01:00
initramfs.c	initramfs: debug detected compression method	2014-04-07 16:36:11 -07:00
Kconfig	init/Kconfig: Hide printk log config if CONFIG_PRINTK=n	2014-11-05 13:55:02 +00:00
main.c	param: fix crash on bad kernel arguments	2014-11-27 11:21:42 +00:00
Makefile	init_task: Replace CONFIG_HAVE_GENERIC_INIT_TASK	2012-05-05 13:00:46 +02:00
noinitramfs.c	init: mark __user address space on string literals	2010-10-26 16:52:15 -07:00
version.c	proc: Split the namespace stuff out into linux/proc_ns.h	2013-05-01 17:29:39 -04:00