linux/drivers/infiniband
Jason Gunthorpe d1e09f304a IB/uverbs: Fix race between uverbs_close and remove_one
Fixes an oops that might happen if uverbs_close races with
remove_one.

Both contexts may run ib_uverbs_cleanup_ucontext, it depends
on the flow.

Currently, there is no protection for a case that remove_one
didn't make the cleanup it runs to its end, the underlying
ib_device was freed then uverbs_close will call
ib_uverbs_cleanup_ucontext and OOPs.

Above might happen if uverbs_close deleted the file from the list
then remove_one didn't find it and runs to its end.

Fixes to protect against that case by a new cleanup lock so that
ib_uverbs_cleanup_ucontext will be called always before that
remove_one is ended.

Fixes: 35d4a0b63d ("IB/uverbs: Fix race between ib_uverbs_open and remove_one")
Reported-by: Devesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
History 2016-08-03 21:03:36 -04:00
..
core IB/uverbs: Fix race between uverbs_close and remove_one 2016-08-03 21:03:36 -04:00
hw IB/mthca: Clean up error unwind flow in mthca_reset() 2016-08-03 21:03:35 -04:00
sw IB/rdmavt: Disable by default 2016-08-03 21:03:31 -04:00
ulp IB/ipoib: Report SG feature regardless of HW UD CSUM capability 2016-08-03 21:03:32 -04:00
Kconfig IB/hfi1: Move driver out of staging 2016-05-26 11:35:14 -04:00
Makefile IB/rdmavt: Create module framework and handle driver registration 2016-03-10 20:37:04 -05:00