kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-11-02 19:05:42 +00:00
Code Issues Releases Packages Activity
linux/drivers/net/vxge
History
Stanislaw Gruszka 673e63c688 net: fix ethtool->set_flags not intended -EINVAL return value 
After commit d5dbda2380 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
History 2011-03-27 23:35:24 -07:00
..
Makefile vxge: Update copyright information 2010-07-15 20:46:22 -07:00
vxge-config.c Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2011-02-04 14:28:58 -08:00
vxge-config.h vxge: MSIX one shot mode 2011-01-19 23:18:14 -08:00
vxge-ethtool.c net: fix ethtool->set_flags not intended -EINVAL return value 2011-03-27 23:35:24 -07:00
vxge-ethtool.h vxge: Update copyright information 2010-07-15 20:46:22 -07:00
vxge-main.c net: use pci_dev->revision, again 2011-02-28 11:57:33 -08:00
vxge-main.h vxge: MSIX one shot mode 2011-01-19 23:18:14 -08:00
vxge-reg.h vxge: correct multi-function detection 2010-11-11 09:30:23 -08:00
vxge-traffic.c vxge: MSIX one shot mode 2011-01-19 23:18:14 -08:00
vxge-traffic.h vxge: MSIX one shot mode 2011-01-19 23:18:14 -08:00
vxge-version.h vxge: update driver version 2011-01-19 23:18:14 -08:00