linux/tools/lib/perf
Ian Rogers be113e082b libperf evlist: Avoid out-of-bounds access
[ Upstream commit 1947b92464 ]

Parallel testing appears to show a race between allocating and setting
evsel ids. As there is a bounds check on the xyarray it yields a segv
like:

```
AddressSanitizer:DEADLYSIGNAL

=================================================================

==484408==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000010

==484408==The signal is caused by a WRITE memory access.

==484408==Hint: address points to the zero page.

    #0 0x55cef5d4eff4 in perf_evlist__id_hash tools/lib/perf/evlist.c:256
    #1 0x55cef5d4f132 in perf_evlist__id_add tools/lib/perf/evlist.c:274
    #2 0x55cef5d4f545 in perf_evlist__id_add_fd tools/lib/perf/evlist.c:315
    #3 0x55cef5a1923f in store_evsel_ids util/evsel.c:3130
    #4 0x55cef5a19400 in evsel__store_ids util/evsel.c:3147
    #5 0x55cef5888204 in __run_perf_stat tools/perf/builtin-stat.c:832
    #6 0x55cef5888c06 in run_perf_stat tools/perf/builtin-stat.c:960
    #7 0x55cef58932db in cmd_stat tools/perf/builtin-stat.c:2878
...
```

Avoid this crash by early exiting the perf_evlist__id_add_fd and
perf_evlist__id_add is the access is out-of-bounds.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240229070757.796244-1-irogers@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-04-13 13:01:45 +02:00
..
Documentation libperf: Add evsel mmap support 2021-04-15 16:38:51 -03:00
include libperf evlist: Avoid out-of-bounds access 2024-04-13 13:01:45 +02:00
tests libperf tests: Fix test_stat_cpu 2021-10-14 15:41:35 -03:00
Build libperf: Change tests to single static and shared binaries 2021-07-07 11:41:58 -03:00
core.c libperf: Move to tools/lib/perf 2020-01-06 11:46:09 -03:00
cpumap.c libperf cpumap: Take into advantage it is sorted to optimize perf_cpu_map__max() 2021-08-31 16:17:02 -03:00
evlist.c libperf evlist: Avoid out-of-bounds access 2024-04-13 13:01:45 +02:00
evsel.c libperf evsel: Make use of FD robust. 2021-09-18 17:43:06 -03:00
internal.h libperf: Move to tools/lib/perf 2020-01-06 11:46:09 -03:00
lib.c libperf: Move to tools/lib/perf 2020-01-06 11:46:09 -03:00
libperf.map libperf: Adopt evlist__set_leader() from tools/perf as perf_evlist__set_leader() 2021-07-09 14:04:32 -03:00
libperf.pc.template libperf: Move to tools/lib/perf 2020-01-06 11:46:09 -03:00
Makefile libperf: Change tests to single static and shared binaries 2021-07-07 11:41:58 -03:00
mmap.c libperf: Add support for user space counter access 2021-04-20 08:10:45 -03:00
threadmap.c libperf: Move to tools/lib/perf 2020-01-06 11:46:09 -03:00
xyarray.c libperf: Move to tools/lib/perf 2020-01-06 11:46:09 -03:00