Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Julien Massot 68e5579f4d media: ti: j721e-csi2rx: fix list_del corruption ... commit ae42c6fe53 upstream. If ti_csi2rx_start_dma() fails in ti_csi2rx_dma_callback(), the buffer is marked done with VB2_BUF_STATE_ERROR but is not removed from the DMA queue. This causes the same buffer to be retried in the next iteration, resulting in a double list_del() and eventual list corruption. Fix this by removing the buffer from the queue before calling vb2_buffer_done() on error. This resolves a crash due to list_del corruption: [ 37.811243] j721e-csi2rx 30102000.ticsi2rx: Failed to queue the next buffer for DMA [ 37.832187] slab kmalloc-2k start ffff00000255b000 pointer offset 1064 size 2048 [ 37.839761] list_del corruption. next->prev should be ffff00000255bc28, but was ffff00000255d428. (next=ffff00000255b428) [ 37.850799] ------------[ cut here ]------------ [ 37.855424] kernel BUG at lib/list_debug.c:65! [ 37.859876] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP [ 37.866061] Modules linked in: i2c_dev usb_f_rndis u_ether libcomposite dwc3 udc_core usb_common aes_ce_blk aes_ce_cipher ghash_ce gf128mul sha1_ce cpufreq_dt dwc3_am62 phy_gmii_sel sa2ul [ 37.882830] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.16.0-rc3+ #28 VOLUNTARY [ 37.890851] Hardware name: Bosch STLA-GSRV2-B0 (DT) [ 37.895737] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 37.902703] pc : __list_del_entry_valid_or_report+0xdc/0x114 [ 37.908390] lr : __list_del_entry_valid_or_report+0xdc/0x114 [ 37.914059] sp : ffff800080003db0 [ 37.917375] x29: ffff800080003db0 x28: 0000000000000007 x27: ffff800080e50000 [ 37.924521] x26: 0000000000000000 x25: ffff0000016abb50 x24: dead000000000122 [ 37.931666] x23: ffff0000016abb78 x22: ffff0000016ab080 x21: ffff800080003de0 [ 37.938810] x20: ffff00000255bc00 x19: ffff00000255b800 x18: 000000000000000a [ 37.945956] x17: 20747562202c3832 x16: 6362353532303030 x15: 0720072007200720 [ 37.953101] x14: 0720072007200720 x13: 0720072007200720 x12: 00000000ffffffea [ 37.960248] x11: ffff800080003b18 x10: 00000000ffffefff x9 : ffff800080f5b568 [ 37.967396] x8 : ffff800080f5b5c0 x7 : 0000000000017fe8 x6 : c0000000ffffefff [ 37.974542] x5 : ffff00000fea6688 x4 : 0000000000000000 x3 : 0000000000000000 [ 37.981686] x2 : 0000000000000000 x1 : ffff800080ef2b40 x0 : 000000000000006d [ 37.988832] Call trace: [ 37.991281] __list_del_entry_valid_or_report+0xdc/0x114 (P) [ 37.996959] ti_csi2rx_dma_callback+0x84/0x1c4 [ 38.001419] udma_vchan_complete+0x1e0/0x344 [ 38.005705] tasklet_action_common+0x118/0x310 [ 38.010163] tasklet_action+0x30/0x3c [ 38.013832] handle_softirqs+0x10c/0x2e0 [ 38.017761] __do_softirq+0x14/0x20 [ 38.021256] ____do_softirq+0x10/0x20 [ 38.024931] call_on_irq_stack+0x24/0x60 [ 38.028873] do_softirq_own_stack+0x1c/0x40 [ 38.033064] __irq_exit_rcu+0x130/0x15c [ 38.036909] irq_exit_rcu+0x10/0x20 [ 38.040403] el1_interrupt+0x38/0x60 [ 38.043987] el1h_64_irq_handler+0x18/0x24 [ 38.048091] el1h_64_irq+0x6c/0x70 [ 38.051501] default_idle_call+0x34/0xe0 (P) [ 38.055783] do_idle+0x1f8/0x250 [ 38.059021] cpu_startup_entry+0x34/0x3c [ 38.062951] rest_init+0xb4/0xc0 [ 38.066186] console_on_rootfs+0x0/0x6c [ 38.070031] __primary_switched+0x88/0x90 [ 38.074059] Code: b00037e0 91378000 f9400462 97e9bf49 (d4210000) [ 38.080168] ---[ end trace 0000000000000000 ]--- [ 38.084795] Kernel panic - not syncing: Oops - BUG: Fatal exception in interrupt [ 38.092197] SMP: stopping secondary CPUs [ 38.096139] Kernel Offset: disabled [ 38.099631] CPU features: 0x0000,00002000,02000801,0400420b [ 38.105202] Memory Limit: none [ 38.108260] ---[ end Kernel panic - not syncing: Oops - BUG: Fatal exception in interrupt ]--- Fixes: b4a3d877dc ("media: ti: Add CSI2RX support for J721E") Cc: stable@vger.kernel.org Suggested-by: Sjoerd Simons <sjoerd@collabora.com> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com> Signed-off-by: Julien Massot <julien.massot@collabora.com> Reviewed-by: Jai Luthra <jai.luthra@linux.dev> Tested-by: Dirk Behme <dirk.behme@de.bosch.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2025-08-15 12:14:14 +02:00
..
cec	media: pulse8-cec: fix data timestamp at pulse8_setup()	2024-10-18 10:43:03 +02:00
common	media: videobuf2: use sgtable-based scatterlist wrappers	2025-06-27 11:11:18 +01:00
dvb-core	media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set	2024-11-06 22:32:52 +01:00
dvb-frontends	objtool, media: dib8000: Prevent divide-by-zero in dib8000_set_dds()	2025-04-10 14:39:26 +02:00
firewire	media: firewire: firedtv-avc.c: replace BUG with proper, error return	2023-08-10 07:58:37 +02:00
i2c	media: i2c: imx335: Fix frame size enumeration	2025-06-27 11:11:17 +01:00
mc	[tree-wide] finally take no_llseek out	2024-09-27 08:18:43 -07:00
mmc	media: mmc: siano: simplify module initialization	2024-04-08 13:48:19 +02:00
pci	media: ipu6: Remove workaround for Meteor Lake ES2	2025-06-27 11:11:17 +01:00
platform	media: ti: j721e-csi2rx: fix list_del corruption	2025-08-15 12:14:14 +02:00
radio	media: wl128x: Fix atomicity violation in fmc_send_cmd()	2024-12-05 14:02:56 +01:00
rc	media: streamzap: prevent processing IR data on URB failure	2025-04-20 10:15:35 +02:00
spi	media: gs1662: remove unused struct 'gs_reg_fmt_custom'	2024-05-31 13:51:16 +02:00
test-drivers	media: vivid: Change the siize of the composing	2025-06-27 11:11:18 +01:00
tuners	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
usb	media: uvcvideo: Rollback non processed entities on error	2025-07-06 11:01:47 +02:00
v4l2-core	media: v4l2-ctrls: Fix H264 SEPARATE_COLOUR_PLANE check	2025-08-15 12:13:50 +02:00
Kconfig	media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y	2022-12-07 17:58:46 +01:00
Makefile	media: Makefiles: remove extra spaces	2022-03-12 16:59:52 +01:00