linux/drivers/usb
Robert Schlabbach d83de3f979 usb: core: Fix USB 3.0 devices lost in NOTATTACHED state after a hub port reset
[ Upstream commit fb6d1f7df5 ]

Fix USB 3.0 devices lost in NOTATTACHED state after a hub port reset.

Dissolve the function hub_port_finish_reset() completely and divide the
actions to be taken into those which need to be done after each reset
attempt and those which need to be done after the full procedure is
complete, and place them in the appropriate places in hub_port_reset().
Also, remove an unneeded forward declaration of hub_port_reset().

Verbose Problem Description:

USB 3.0 devices may be "lost for good" during a hub port reset.
This makes Linux unable to boot from USB 3.0 devices in certain
constellations of host controllers and devices, because the USB device is
lost during initialization, preventing the rootfs from being mounted.

The underlying problem is that in the affected constellations, during the
processing inside hub_port_reset(), the hub link state goes from 0 to
SS.inactive after the initial reset, and back to 0 again only after the
following "warm" reset.

However, hub_port_finish_reset() is called after each reset attempt and
sets the state the connected USB device based on the "preliminary" status
of the hot reset to USB_STATE_NOTATTACHED due to SS.inactive, yet when
the following warm reset is complete and hub_port_finish_reset() is
called again, its call to set the device to USB_STATE_DEFAULT is blocked
by usb_set_device_state() which does not allow taking USB devices out of
USB_STATE_NOTATTACHED state.

Thanks to Alan Stern for guiding me to the proper solution and how to
submit it.

Link: http://lkml.kernel.org/r/trinity-25981484-72a9-4d46-bf17-9c1cf9301a31-1432073240136%20()%203capp-gmx-bs27
Signed-off-by: Robert Schlabbach <robert_s@gmx.net>
Cc: stable <stable@vger.kernel.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
History 2015-07-03 23:02:22 -04:00
..
atm usb: delete non-required instances of include <linux/init.h> 2014-01-08 15:01:39 -08:00
c67x00 USB: c67x00: correct spelling mistakes in comments 2014-01-08 15:05:14 -08:00
chipidea usb: chipidea: otg: remove mutex unlock and lock while stop and start role 2015-05-17 19:12:38 -04:00
class cdc-acm: Add support of ATOL FPrint fiscal printers 2015-07-03 12:34:28 -04:00
common usb: common: otg-fsm: only signal connect after switching to peripheral 2015-04-16 20:11:40 -04:00
core usb: core: Fix USB 3.0 devices lost in NOTATTACHED state after a hub port reset 2015-07-03 23:02:22 -04:00
dwc2 usb: dwc2: hcd: use new USB_RESUME_TIMEOUT 2015-06-28 13:39:22 -04:00
dwc3 usb: dwc3: gadget: don't clear EP_BUSY too early 2015-07-03 23:02:21 -04:00
early USB: ehci-dbgp: drop dead code. 2013-09-26 16:25:21 -07:00
gadget usb: gadget: configfs: Fix interfaces array NULL-termination 2015-06-10 13:42:20 -04:00
host xhci: gracefully handle xhci_irq dead device 2015-06-10 13:42:17 -04:00
image USB: image: correct spelling mistake in comment 2014-01-08 15:08:14 -08:00
misc usb: rename phy to usb_phy in HCD 2014-09-29 11:52:59 -04:00
mon USB: regroup all depends on USB within an if USB block 2013-04-09 16:49:07 -07:00
musb usb: musb: use new USB_RESUME_TIMEOUT 2015-05-17 19:11:59 -04:00
phy usb: phy: Find the right match in devm_usb_phy_match 2015-05-17 19:11:58 -04:00
renesas_usbhs usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable() 2015-01-16 06:59:51 -08:00
serial USB: serial: ftdi_sio: Add support for a Motion Tracker Development Board 2015-07-03 12:34:39 -04:00
storage usb-storage: Add NO_WP_DETECT quirk for Lacie 059f:0651 devices 2015-06-10 13:42:20 -04:00
usbip usbip: remove struct usb_device_id table 2014-08-25 10:40:58 -07:00
wusbcore usb: hub: rename khubd to hub_wq in documentation and comments 2014-09-23 22:33:19 -07:00
Kconfig usb: Add LED triggers for USB activity 2014-09-25 17:05:12 +02:00
Makefile usbip: move usbip kernel code out of staging 2014-08-25 10:40:06 -07:00
README usb: hub: rename khubd to hub_wq in documentation and comments 2014-09-23 22:33:19 -07:00
usb-skeleton.c usb: delete non-required instances of include <linux/init.h> 2014-01-08 15:01:39 -08:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.