Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Eric Farman d33c0c5637 vfio/ccw: remove WARN_ON during shutdown ... [ Upstream commit 1c06bb87af ] The logic in vfio_ccw_sch_shutdown() always assumed that the input subchannel would point to a vfio_ccw_private struct, without checking that one exists. The blamed commit put in a check for this scenario, to prevent the possibility of a missing private. The trouble is that check was put alongside a WARN_ON(), presuming that such a scenario would be a cause for concern. But this can be triggered by binding a subchannel to vfio-ccw, and rebooting the system before starting the mdev (via "mdevctl start" or similar) or after stopping it. In those cases, shutdown doesn't need to worry because either the private was never allocated, or it was cleaned up by vfio_ccw_mdev_remove(). Remove the WARN_ON() piece of this check, since there are plausible scenarios where private would be NULL in this path. Fixes: 9e6f07cd1e ("vfio/ccw: create a parent struct") Signed-off-by: Eric Farman <farman@linux.ibm.com> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com> Link: https://lore.kernel.org/r/20230210174227.2256424-1-farman@linux.ibm.com Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2023-03-10 09:28:21 +01:00
..
block	s390/dasd: Fix potential memleak in dasd_eckd_init()	2023-03-10 09:27:56 +01:00
char	s390/early: fix sclp_early_sccb variable lifetime	2023-03-10 09:28:06 +01:00
cio	vfio/ccw: remove WARN_ON during shutdown	2023-03-10 09:28:21 +01:00
crypto	s390: vfio-ap: tighten the NIB validity check	2023-03-10 09:28:17 +01:00
net	s390/qeth: convert sysfs snprintf to sysfs_emit	2022-12-28 12:10:42 +00:00
scsi	Random number generator updates for Linux 6.2-rc1.	2022-12-12 16:22:22 -08:00
virtio	virtio: Revert "virtio: find_vqs() add arg sizes"	2022-08-16 01:40:24 -04:00
Makefile	s390: remove pointless drivers-y in drivers/s390/Makefile	2019-09-16 13:21:51 +02:00