linux/drivers/dpll
Michal Swiatkowski cb2f8a5c1f dpll: fix xa_alloc_cyclic() error handling
[ Upstream commit 3614bf9013 ]

In case of returning 1 from xa_alloc_cyclic() (wrapping) ERR_PTR(1) will
be returned, which will cause IS_ERR() to be false. Which can lead to
dereference not allocated pointer (pin).

Fix it by checking if err is lower than zero.

This wasn't found in real usecase, only noticed. Credit to Pierre.

Fixes: 97f265ef7f ("dpll: allocate pin ids in cycle")
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2025-03-28 22:03:27 +01:00
..
dpll_core.c dpll: fix xa_alloc_cyclic() error handling 2025-03-28 22:03:27 +01:00
dpll_core.h dpll: rely on rcu for netdev_dpll_pin() 2024-02-26 18:39:34 -08:00
dpll_netlink.c dpll: add Embedded SYNC feature for a pin 2024-08-26 19:21:14 -07:00
dpll_netlink.h dpll: netlink: Add DPLL framework base functions 2023-09-17 11:50:20 +01:00
dpll_nl.c dpll: add Embedded SYNC feature for a pin 2024-08-26 19:21:14 -07:00
dpll_nl.h dpll: fix possible deadlock during netlink dump operation 2024-02-08 18:29:21 -08:00
Kconfig dpll: indent DPLL option type by a tab 2024-03-25 19:40:23 -07:00
Makefile dpll: core: Add DPLL framework base functions 2023-09-17 11:50:20 +01:00