kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-18 19:12:56 +00:00
Code Issues Releases Packages Activity
linux/drivers/video/backlight
History
Bhushan Shah d361b9725e backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F 
commit 06168a64b1 upstream.

In the lm3630a_chip_init we try to write to 0x50 register, which is
higher value then the max_register value, this resulted in regmap_write
return -EIO.

Fix this by bumping REG_MAX value to 0x50.

This code was introduced with the chip revision in commit 28e64a68a2,
however setting filter strength was failing silently because it used
unsigned int for storing and comparing the return values. Bug related to
signedness was fixed in 2a0c316bf3, which made it error out correctly
instead of failing silently.

I found this issue by using this driver on LGE Nexus 5 (hammerhead).
After this commit lm3630a_chip_init succeeds instead of failing with
-EIO.

Fixes: 28e64a68a2 ("backlight: lm3630: apply chip revision")
Fixes: 2a0c316bf3 ("drivers/video/backlight/lm3630a_bl.c: fix
signedness bug in lm3630a_chip_init()")

Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Bhushan Shah <bshah@kde.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2017-11-26 13:50:13 +00:00
..
88pm860x_bl.c backlight: 88pm860x_bl: use devm_backlight_device_register() 2013-11-13 12:09:16 +09:00
aat2870_bl.c backlight: aat2870: remove unnecessary OOM messages 2014-04-03 16:21:09 -07:00
adp5520_bl.c backlight: adp5520: use devm_backlight_device_register() 2013-11-13 12:09:16 +09:00
adp8860_bl.c backlight: adp8860: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
adp8870_bl.c backlight: adp8870: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ams369fg06.c backlight: ams369fg06: use devm_{backlight,lcd}_device_register() 2013-11-13 12:09:20 +09:00
apple_bl.c ACPI: Remove useless type argument of driver .remove() operation 2013-01-26 00:37:24 +01:00
as3711_bl.c backlight: as3711_bl: use devm_backlight_device_register() 2013-11-13 12:09:16 +09:00
atmel-pwm-bl.c backlight: atmel-pwm-bl: use gpio_request_one 2013-11-13 12:09:22 +09:00
backlight.c backlight: Add backlight device (un)registration notification 2014-05-27 01:29:01 +02:00
bd6107.c backlight: bd6107: use devm_backlight_device_register() 2013-11-13 12:09:17 +09:00
corgi_lcd.c backlight: corgi_lcd: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
cr_bllcd.c backlight: cr_bllcd: use devm_{backlight,lcd}_device_register() 2013-11-13 12:09:20 +09:00
da903x_bl.c backlight: da903x_bl: use devm_backlight_device_register() 2013-11-13 12:09:17 +09:00
da9052_bl.c backlight: da9052_bl: use devm_backlight_device_register() 2013-11-13 12:09:17 +09:00
ep93xx_bl.c backlight: ep93xx: use devm_backlight_device_register() 2013-11-13 12:09:17 +09:00
generic_bl.c backlight: generic_bl: use devm_backlight_device_register() 2013-11-13 12:09:17 +09:00
gpio_backlight.c backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip 2014-06-05 10:00:53 +01:00
hp680_bl.c backlight: hp680_bl: use devm_backlight_device_register() 2014-01-23 16:36:56 -08:00
hx8357.c backlight: hx8357: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili922x.c backlight: ili922x: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili9320.c backlight: ili9320: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili9320.h backlight: vgg2432a4: convert vgg2432a4_driver to dev_pm_ops 2013-04-29 18:28:18 -07:00
jornada720_bl.c backlight: jornada720: use devm_backlight_device_register() 2014-01-23 16:36:56 -08:00
jornada720_lcd.c backlight: jornada720: use devm_lcd_device_register() 2014-01-23 16:36:56 -08:00
kb3886_bl.c backlight: kb3886_bl: fix incorrect placement of __initdata marker 2014-01-23 16:36:57 -08:00
Kconfig video/backlight: LP8788 needs PWM 2014-04-28 11:22:01 +01:00
l4f00242t03.c backlight: l4f00242t03: remove unnecessary OOM messages 2014-04-03 16:21:11 -07:00
lcd.c drivers/video/backlight/lcd.c: call put_device if device_register fails 2014-01-30 16:56:54 -08:00
ld9040.c backlight: ld9040: use devm_{backlight,lcd}_device_register() 2013-11-13 12:09:20 +09:00
ld9040_gamma.h backlight: ld9040: Staticize local variable gamma_table 2013-11-13 12:09:15 +09:00
lm3533_bl.c backlight: lm3533_bl: remove unnecessary OOM messages 2014-04-03 16:21:11 -07:00
lm3630a_bl.c backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F 2017-11-26 13:50:13 +00:00
lm3639_bl.c backlight: lm3639: Use devm_backlight_device_register() 2014-04-08 13:20:41 +01:00
lms283gf05.c backlight: lms283gf05: remove unnecessary OOM messages 2014-04-03 16:21:11 -07:00
lms501kf03.c backlight: lms501kf03: use devm_lcd_device_register() 2013-11-13 12:09:19 +09:00
locomolcd.c backlight: locomolcd: convert locomolcd to dev_pm_ops 2013-04-29 18:28:16 -07:00
lp855x_bl.c backlight: lp855x: remove unnecessary parentheses 2014-01-23 16:36:57 -08:00
lp8788_bl.c backlight: lp8788: remove unnecessary parentheses 2014-01-23 16:36:57 -08:00
ltv350qv.c backlight: ltv350qv: use devm_lcd_device_register() 2013-11-13 12:09:19 +09:00
ltv350qv.h backlight: Add Samsung LTV350QV LCD driver 2007-10-11 22:24:12 +01:00
lv5207lp.c backlight: lv5207lp: use devm_backlight_device_register() 2013-11-13 12:09:18 +09:00
Makefile backlight: lm3630: apply chip revision 2013-11-13 12:09:15 +09:00
max8925_bl.c backlight: max8925_bl: use devm_backlight_device_register() 2013-11-13 12:09:18 +09:00
omap1_bl.c backlight: omap1: use devm_backlight_device_register() 2014-01-23 16:36:56 -08:00
ot200_bl.c backlight: ot200_bl: use devm_backlight_device_register() 2014-01-23 16:36:56 -08:00
pandora_bl.c backlight: pandora_bl: use devm_backlight_device_register() 2013-11-13 12:09:18 +09:00
pcf50633-backlight.c backlight: pcf50633: use devm_backlight_device_register() 2013-11-13 12:09:18 +09:00
platform_lcd.c backlight: platform_lcd: remove unnecessary OOM messages 2014-04-03 16:21:11 -07:00
pwm_bl.c pwm-backlight: retrieve configured PWM period 2014-05-21 11:19:45 +02:00
s6e63m0.c video/backlight: s6e63m0: Fix string type mismatch 2014-05-07 11:12:51 +01:00
s6e63m0_gamma.h backlight: add S6E63M0 AMOLED LCD Panel driver 2010-05-26 17:34:16 +01:00
tdo24m.c backlight: tdo24m: use devm_lcd_device_register() 2013-11-13 12:09:20 +09:00
tosa_bl.c backlight: tosa: use devm_backlight_device_register() 2014-01-23 16:36:56 -08:00
tosa_lcd.c backlight: tosa: use devm_lcd_device_register() 2014-01-23 16:36:57 -08:00
tps65217_bl.c backlight: tps65217_bl: remove unnecessary OOM messages 2014-04-03 16:21:11 -07:00
vgg2432a4.c backlight: vgg2432a4: convert vgg2432a4_driver to dev_pm_ops 2013-04-29 18:28:18 -07:00
wm831x_bl.c backlight: wm831x_bl: use devm_backlight_device_register() 2013-11-13 12:09:18 +09:00