Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Jin Yao 61415418cd perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target ... commit 80f62589fa upstream. When the jump instruction is displayed at the row 0 in annotate view, the arrow is broken. An example: 16.86 │ ┌──je 82 0.01 │ movsd (%rsp),%xmm0 │ movsd 0x8(%rsp),%xmm4 │ movsd 0x8(%rsp),%xmm1 │ movsd (%rsp),%xmm3 │ divsd %xmm4,%xmm0 │ divsd %xmm3,%xmm1 │ movsd (%rsp),%xmm2 │ addsd %xmm1,%xmm0 │ addsd %xmm2,%xmm0 │ movsd %xmm0,(%rsp) │82: sub $0x1,%ebx 83.03 │ ↑ jne 38 │ add $0x10,%rsp │ xor %eax,%eax │ pop %rbx │ ← retq The patch increments the row number before checking with 0. Signed-off-by: Yao Jin <yao.jin@linux.intel.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kan Liang <kan.liang@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Fixes: 944e1abed9 ("perf ui browser: Add method to draw up/down arrow line") Link: http://lkml.kernel.org/r/1496901704-30275-1-git-send-email-yao.jin@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2017-07-27 15:08:06 -07:00
..
accounting	tools: move accounting tool from Documentation	2016-09-23 13:07:15 -06:00
arch	tools arch: Sync arch/x86/lib/memcpy_64.S with the kernel	2017-07-05 14:40:29 +02:00
build	tools build: Add feature detection for g++	2016-10-05 19:59:35 -03:00
cgroup	cgroups: fix cgroup_event_listener error handling	2013-01-08 10:00:44 -08:00
firewire	tools/firewire: nosy-dump: check for allocation failure	2012-12-02 20:10:18 +01:00
gpio	tools/gpio: fix gpio-event-mon header comment	2016-08-08 09:50:22 +02:00
hv	Drivers: hv: utils: Check VSS daemon is listening before a hot backup	2016-09-02 17:22:51 +02:00
iio	Second set of iio new device support, features and cleanups for the 4.9 cycle.	2016-09-14 20:42:03 +02:00
include	tools include: Add a __fallthrough statement	2017-07-15 12:16:12 +02:00
kvm/kvm_stat	tools: kvm_stat: Add comments	2016-05-25 16:12:06 +02:00
laptop	tools: move laptops dslm tool from Documentation	2016-09-23 13:07:21 -06:00
lguest	tools/lguest: Don't bork the terminal in case of wrong args	2016-09-08 08:05:24 +02:00
lib	tools/lib/lockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain/: Depth	2017-07-21 07:42:20 +02:00
net	tools: bpf_jit_disasm: check for klogctl failure	2016-05-08 23:32:59 -04:00
nfsd	NFSD: Added fault injection script	2011-11-07 21:10:47 -05:00
objtool	objtool: Fix another GCC jump table detection issue	2017-07-05 14:40:30 +02:00
pcmcia	tools: move pcmcia crc32hash tool from Documentation	2016-09-23 13:07:27 -06:00
perf	perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target	2017-07-27 15:08:06 -07:00
power	cpupower: Fix turbo frequency reporting for pre-Sandy Bridge cores	2017-05-14 14:00:14 +02:00
scripts	tools build: Fix objtool build with ARCH=x86_64	2016-07-22 16:37:44 -03:00
spi	Merge remote-tracking branches 'spi/topic/ti-qspi', 'spi/topic/tools', 'spi/topic/txx9' and 'spi/topic/xlp' into spi-next	2016-09-30 09:14:22 -07:00
testing	selftests/capabilities: Fix the test_execve test	2017-07-21 07:42:22 +02:00
thermal/tmon	tools/thermal: tmon: use pkg-config also for CFLAGS	2015-10-10 11:32:31 +08:00
time	tools: add script to test udelay	2014-07-23 10:16:38 -07:00
usb	usbip: adding names db to port operation	2016-05-03 14:32:07 -07:00
virtio	tools/virtio/ringtest: fix run-on-all.sh for offline cpus	2017-01-26 08:24:46 +01:00
vm	tools/vm/page_owner: increase temporary buffer size	2016-07-26 16:19:19 -07:00
Makefile	tools/gpio: add install section	2016-06-23 11:07:13 +02:00