kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-28 20:03:05 +00:00
Code Issues Releases Packages Activity
linux/drivers/opp
History
Neil Armstrong 84ff05c9bd OPP: fix dev_pm_opp_find_bw_*() when bandwidth table not initialized 
[ Upstream commit b44b9bc7ca ]

If a driver calls dev_pm_opp_find_bw_ceil/floor() the retrieve bandwidth
from the OPP table but the bandwidth table was not created because the
interconnect properties were missing in the OPP consumer node, the
kernel will crash with:

Unable to handle kernel NULL pointer dereference at virtual address 0000000000000004
...
pc : _read_bw+0x8/0x10
lr : _opp_table_find_key+0x9c/0x174
...
Call trace:
  _read_bw+0x8/0x10 (P)
  _opp_table_find_key+0x9c/0x174 (L)
  _find_key+0x98/0x168
  dev_pm_opp_find_bw_ceil+0x50/0x88
...

In order to fix the crash, create an assert function to check
if the bandwidth table was created before trying to get a
bandwidth with _read_bw().

Fixes: add1dc094a ("OPP: Use generic key finding helpers for bandwidth key")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2025-02-08 09:51:47 +01:00
..
core.c OPP: fix dev_pm_opp_find_bw_*() when bandwidth table not initialized 2025-02-08 09:51:47 +01:00
cpu.c OPP: Fix argument name in doc comment 2023-08-18 10:55:49 +05:30
debugfs.c OPP: debugfs: Fix warning around icc_get_name() 2024-03-26 18:19:40 -04:00
Kconfig drivers/opp: Remove "select SRCU" 2023-01-05 11:47:21 +05:30
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
of.c OPP: Properly propagate error along when failing to get icc_path 2023-06-27 07:35:14 +05:30
opp.h OPP: Simplify the over-designed pstate <-> level dance 2023-06-19 09:50:09 +05:30
ti-opp-supply.c OPP: ti: Fix ti_opp_supply_probe wrong return values 2024-08-03 08:53:27 +02:00