Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Andrii Nakryiko fcc09ef87e libbpf: Fix btf_dump's packed struct determination ... [ Upstream commit 4fb877aaa1 ] Fix bug in btf_dump's logic of determining if a given struct type is packed or not. The notion of "natural alignment" is not needed and is even harmful in this case, so drop it altogether. The biggest difference in btf_is_struct_packed() compared to its original implementation is that we don't really use btf__align_of() to determine overall alignment of a struct type (because it could be 1 for both packed and non-packed struct, depending on specifci field definitions), and just use field's actual alignment to calculate whether any field is requiring packing or struct's size overall necessitates packing. Add two simple test cases that demonstrate the difference this change would make. Fixes: ea2ce1ba99 ("libbpf: Fix BTF-to-C converter's padding logic") Reported-by: Eduard Zingerman <eddyz87@gmail.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Eduard Zingerman <eddyz87@gmail.com> Link: https://lore.kernel.org/bpf/20221215183605.4149488-1-andrii@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2023-04-05 11:25:02 +02:00
..
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest.pl: Add RUN_TIMEOUT option with default unlimited	2023-03-10 09:40:10 +01:00
kunit	kunit: tool: Import missing importlib.abc	2022-02-23 12:03:04 +01:00
nvdimm	memremap: remove support for external pgmap refcounts	2022-08-17 14:23:43 +02:00
radix-tree	idr test suite: Improve reporting from idr_find_test_1	2021-04-01 07:50:42 -04:00
scatterlist	Merge branch 'akpm' (patches from Andrew)	2021-09-03 10:08:28 -07:00
selftests	libbpf: Fix btf_dump's packed struct determination	2023-04-05 11:25:02 +02:00
vsock	vsock_diag_test: remove free_sock_stat() call in test_no_sockets	2021-10-15 17:21:34 -07:00