Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Tejun Heo b44b214026 kernfs: add back missing error check in kernfs_fop_mmap() ... While updating how mmap enabled kernfs files are handled by lockdep, 9b2db6e189 ("sysfs: bail early from kernfs_file_mmap() to avoid spurious lockdep warning") inadvertently dropped error return check from kernfs_file_mmap(). The intention was just dropping "if (ops->mmap)" check as the control won't reach the point if the mmap callback isn't implemented, but I mistakenly removed the error return check together with it. This led to Xorg crash on i810 which was reported and bisected to the commit and then to the specific change by Tobias. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-and-bisected-by: Tobias Powalowski <tobias.powalowski@googlemail.com> Tested-by: Tobias Powalowski <tobias.powalowski@googlemail.com> References: http://lkml.kernel.org/g/533D01BD.1010200@googlemail.com Cc: stable <stable@vger.kernel.org> # 3.14 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2014-04-25 12:25:13 -07:00
..
dir.c	kernfs: fix a subdir count leak	2014-04-25 12:25:13 -07:00
file.c	kernfs: add back missing error check in kernfs_fop_mmap()	2014-04-25 12:25:13 -07:00
inode.c	kernfs: protect lazy kernfs_iattrs allocation with mutex	2014-04-16 11:54:40 -07:00
Kconfig	kernfs: add CONFIG_KERNFS	2014-02-07 16:08:57 -08:00
kernfs-internal.h	kernfs: fix kernfs_node_from_dentry()	2014-02-14 14:31:37 -08:00
Makefile	sysfs, kernfs: add skeletons for kernfs	2013-11-27 13:28:24 -08:00
mount.c	Merge 3.14-rc5 into driver-core-next	2014-03-02 20:09:08 -08:00
symlink.c	kernfs: remove kernfs_addrm_cxt	2014-02-07 15:42:40 -08:00