Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Ben Pfaff ac30ef832e netlink: Fix handling of error from netlink_dump(). ... netlink_dump() returns a negative errno value on error. Until now, netlink_recvmsg() directly recorded that negative value in sk->sk_err, but that's wrong since sk_err takes positive errno values. (This manifests as userspace receiving a positive return value from the recv() system call, falsely indicating success.) This bug was introduced in the commit that started checking the netlink_dump() return value, commit b44d211 (netlink: handle errors from netlink_dump()). Multithreaded Netlink dumps are one way to trigger this behavior in practice, as described in the commit message for the userspace workaround posted here: http://openvswitch.org/pipermail/dev/2014-June/042339.html This commit also fixes the same bug in netlink_poll(), introduced in commit cd1df525d (netlink: add flow control for memory mapped I/O). Signed-off-by: Ben Pfaff <blp@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>		History 2014-07-09 14:33:47 -07:00
..
af_netlink.c	netlink: Fix handling of error from netlink_dump().	2014-07-09 14:33:47 -07:00
af_netlink.h	netlink: have netlink per-protocol bind function return an error code.	2014-04-22 21:42:26 -04:00
diag.c	netlink: Fix build with mmap disabled.	2013-04-23 15:39:03 -04:00
genetlink.c	genetlink: remove superfluous assignment	2014-06-02 10:36:18 -07:00
Kconfig	netlink: kconfig: move mmap i/o into netlink kconfig	2013-05-01 15:02:42 -04:00
Makefile	netlink: Diag core and basic socket info dumping (v2)	2013-03-21 12:38:03 -04:00