Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Herbert Xu a218ab3060 macvlan: Fix potential use-after free for broadcasts ...

commit 260916dfb4 upstream.

When we postpone a broadcast packet we save the source port in
the skb if it is local.  However, the source port can disappear
before we get a chance to process the packet.

This patch fixes this by holding a ref count on the netdev.

It also delays the skb->cb modification until after we allocate
the new skb as you should not modify shared skbs.

Fixes: 412ca1550c ("macvlan: Move broadcasts into a work queue")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

2016-11-20 01:16:39 +00:00

1272 lines

31 KiB

Raw Permalink Blame History