Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Nikolay Borisov 1ab09128f5 dm thin: fix race condition when destroying thin pool workqueue ...

commit 18d03e8c25 upstream.

When a thin pool is being destroyed delayed work items are
cancelled using cancel_delayed_work(), which doesn't guarantee that on
return the delayed item isn't running.  This can cause the work item to
requeue itself on an already destroyed workqueue.  Fix this by using
cancel_delayed_work_sync() which guarantees that on return the work item
is not running anymore.

Fixes: 905e51b39a ("dm thin: commit outstanding data every second")
Fixes: 85ad643b7e ("dm thin: add timeout to stop out-of-data-space mode holding IO forever")
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

2016-02-02 17:38:40 +00:00

3568 lines

88 KiB

Raw Permalink Blame History