linux/sound/firewire
Takashi Sakamoto 3aa1076b7f ALSA: fireworks: accessing to user space outside spinlock
commit 6b1ca4bcad upstream.

In hwdep interface of fireworks driver, accessing to user space is in a
critical section with disabled local interrupt. Depending on architecture,
accessing to user space can cause page fault exception. Then local
processor stores machine status and handles the synchronous event. A
handler corresponding to the event can call task scheduler to wait for
preparing pages. In a case of usage of single core processor, the state to
disable local interrupt is worse because it don't handle usual interrupts
from hardware.

This commit fixes this bug, performing the accessing outside spinlock. This
commit also gives up counting the number of queued response messages to
simplify ring-buffer management.

Reported-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Fixes: 555e8a8f7f14('ALSA: fireworks: Add command/response functionality into hwdep interface')
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2016-11-20 01:17:20 +00:00
..
bebob ALSA: bebob: Use a signed return type for get_formation_index 2016-02-17 10:22:40 +00:00
fireworks ALSA: fireworks: accessing to user space outside spinlock 2016-11-20 01:17:20 +00:00
amdtp.c ALSA: fireworks/firewire-lib: add support for recent firmware quirk 2015-08-27 12:08:13 +01:00
amdtp.h ALSA: fireworks/firewire-lib: add support for recent firmware quirk 2015-08-27 12:08:13 +01:00
cmp.c ALSA: firewire-lib: Fix sparse warning of incorrect type in assignment 2014-05-27 17:34:37 +02:00
cmp.h ALSA: firewire-lib: Add a new function to check others' connection 2014-05-26 14:22:46 +02:00
dice-interface.h ALSA: dice: document quadlet alignment 2013-10-20 22:07:57 +02:00
dice.c ALSA: firewire-lib/dice: add arrangements of PCM pointer and interrupts for Dice quirk 2014-10-05 13:40:54 -07:00
fcp.c ALSA: firewire-lib: Remove a comment about restriction of asynchronous operation 2014-06-03 08:14:21 +02:00
fcp.h ALSA: firewire-lib: Add some AV/C general commands 2014-05-26 14:23:13 +02:00
isight.c ALSA: firewire: Convert to snd_card_new() with a device pointer 2014-02-14 08:13:31 +01:00
iso-resources.c sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed 2011-10-31 19:31:22 -04:00
iso-resources.h firewire: octlet AT payloads can be stack-allocated 2011-05-10 22:53:44 +02:00
Kconfig ALSA: firewire: Fix dependency on PCM and rawmidi 2014-05-30 15:22:06 +02:00
lib.c ALSA: firewire: extend snd_fw_transaction() 2013-10-20 22:07:57 +02:00
lib.h ALSA: firewire: extend snd_fw_transaction() 2013-10-20 22:07:57 +02:00
Makefile ALSA: bebob: Add skelton for BeBoB based devices 2014-05-26 14:29:12 +02:00
packets-buffer.c sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed 2011-10-31 19:31:22 -04:00
packets-buffer.h ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver 2011-03-15 08:42:22 +01:00
scs1x.c ALSA: firewire: Convert to snd_card_new() with a device pointer 2014-02-14 08:13:31 +01:00
speakers.c ALSA: firewire-lib: Add some AV/C general commands 2014-05-26 14:23:13 +02:00