linux/drivers/media
Hans Verkuil a1907fd0fa media: vb2: don't call __vb2_queue_cancel if vb2_start_streaming failed
commit 04990215de upstream.

vb2_start_streaming() already rolls back the buffers, so there is no
need to call __vb2_queue_cancel(). Especially since __vb2_queue_cancel()
does too much, such as zeroing the q->queued_count value, causing vb2
to think that no buffers have been queued.

It appears that this call to __vb2_queue_cancel() is a left-over from
before commit b3379c6201.

Fixes: b3379c6201 ('vb2: only call start_streaming if sufficient buffers are queued')

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
[bwh: Backported to 3.16: adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2019-02-11 17:54:18 +00:00
..
common [media] siano: add support for PCTV 77e 2014-11-17 14:11:49 +00:00
dvb-core media: dvb_frontend: fix locking issues at dvb_frontend_get_event() 2018-11-20 18:04:47 +00:00
dvb-frontends drxd_hard: fix bad alignments 2018-11-20 18:04:45 +00:00
firewire firewire: introduce fw_driver.probe and .remove methods 2013-06-09 18:15:00 +02:00
i2c media: tvp5150: fix width alignment during set_selection() 2019-02-11 17:53:20 +00:00
mmc [media] siano: get rid of CammelCase from smscoreapi.h 2013-03-21 10:03:16 -03:00
parport [media] media: parport: Fix format string mismatch in bw-qcam.c 2014-05-23 12:18:53 -03:00
pci media: pci: cx23885: handle adding to list failure 2019-02-11 17:53:22 +00:00
platform media: exynos4-is: Prevent NULL pointer dereference in __isp_video_try_fmt() 2018-12-16 22:08:09 +00:00
radio [media] si4713: fix Kconfig dependencies 2014-03-28 18:06:55 -03:00
rc ir-core: fix gcc-7 warning on bool arithmetic 2018-11-20 18:06:02 +00:00
tuners xc2028: Fix use-after-free bug properly 2017-02-23 03:54:39 +00:00
usb media: cx231xx: fix potential sign-extension overflow on large shift 2019-02-11 17:53:30 +00:00
v4l2-core media: vb2: don't call __vb2_queue_cancel if vb2_start_streaming failed 2019-02-11 17:54:18 +00:00
Kconfig [media] subdev autoselect only works if I2C and I2C_MUX is selected 2013-12-21 06:03:06 -02:00
Makefile [media] move i2c files into drivers/media/i2c 2012-09-06 18:42:54 -03:00
media-device.c media: media-device: Remove duplicated memset() in media_enum_entities() 2014-09-17 09:21:49 -07:00
media-devnode.c [media] media: Use a better owner for the media device 2014-05-13 13:39:00 -03:00
media-entity.c [media] media: Check for active links on pads with MEDIA_PAD_FL_MUST_CONNECT flag 2013-12-04 15:03:45 -02:00