linux/drivers/video
Vlad Tsyrklevich cce7cb8397 omap2fb: Fix stack memory disclosure
commit a01421e448 upstream.

Using [1] for static analysis I found that the OMAPFB_QUERY_PLANE,
OMAPFB_GET_COLOR_KEY, OMAPFB_GET_DISPLAY_INFO, and OMAPFB_GET_VRAM_INFO
cases could all leak uninitialized stack memory--either due to
uninitialized padding or 'reserved' fields.

Fix them by clearing the shared union used to store copied out data.

[1] https://github.com/vlad902/kernel-uninitialized-memory-checker

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Reviewed-by: Kees Cook <keescook@chromium.org>
Fixes: b39a982dde ("OMAP: DSS2: omapfb driver")
Cc: security@kernel.org
[b.zolnierkie: prefix patch subject with "omap2fb: "]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2019-05-02 21:41:19 +01:00
..
backlight backlight: as3711_bl: Fix Device Tree node leaks 2018-11-20 18:05:13 +00:00
console fbdev: fbcon: Fix unregister crash when more than one framebuffer 2019-04-04 16:14:02 +01:00
fbdev omap2fb: Fix stack memory disclosure 2019-05-02 21:41:19 +01:00
logo video/logo: prevent use of logos after they have been freed 2015-01-16 14:34:19 +00:00
display_timing.c video: add display_timing and videomode 2013-01-24 09:03:04 +01:00
hdmi.c video/hdmi: Rename HDMI_IDENTIFIER to HDMI_IEEE_OUI 2013-08-30 08:42:01 +10:00
Kconfig gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging 2014-06-04 11:06:52 +02:00
Makefile fbdev: sti: don't select CONFIG_VT 2017-08-26 02:14:46 +01:00
of_display_timing.c video: of: display_timing: fix default native-mode setting 2014-05-23 13:31:19 +03:00
of_videomode.c videomode: videomode_from_timing work 2013-03-21 14:34:33 +02:00
vgastate.c vga: vgastate fix 2007-05-08 11:15:32 -07:00
videomode.c videomode: videomode_from_timing work 2013-03-21 14:34:33 +02:00