kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-16 22:39:48 +00:00
Code Issues Releases Packages Activity
linux/fs/pstore
History
Kees Cook 1ed20af255 pstore/ram: Fix failure-path memory leak in ramoops_init 
commit bac6f6cda2 upstream.

As reported by nixiaoming, with some minor clarifications:

1) memory leak in ramoops_register_dummy():
   dummy_data = kzalloc(sizeof(*dummy_data), GFP_KERNEL);
   but no kfree() if platform_device_register_data() fails.

2) memory leak in ramoops_init():
   Missing platform_device_unregister(dummy) and kfree(dummy_data)
   if platform_driver_register(&ramoops_driver) fails.

I've clarified the purpose of ramoops_register_dummy(), and added a
common cleanup routine for all three failure paths to call.

Reported-by: nixiaoming <nixiaoming@huawei.com>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2018-12-16 22:09:31 +00:00
..
ftrace.c pstore: Add hsize argument in write_buf call of pstore_ftrace_call 2013-07-02 18:39:37 +10:00
inode.c sysfs: Create mountpoints with sysfs_create_mount_point 2015-08-20 18:24:03 +01:00
internal.h pstore: Add file extension to pstore file if compressed 2013-08-19 11:53:27 -07:00
Kconfig pstore/Kconfig: Select ZLIB_DEFLATE and ZLIB_INFLATE when PSTORE is selected 2013-08-19 10:18:10 -07:00
Makefile pstore: Add persistent function tracing 2012-07-17 10:05:52 -07:00
platform.c fs/pstore: logging clean-up 2014-06-06 16:08:13 -07:00
ram.c pstore/ram: Fix failure-path memory leak in ramoops_init 2018-12-16 22:09:31 +00:00
ram_core.c pstore: Fix incorrect persistent ram buffer mapping 2018-12-16 22:09:18 +00:00