Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Eric Biggers 056112f96b 509: fix printing uninitialized stack memory when OID is empty ...

commit 8dfd2f22d3 upstream.

Callers of sprint_oid() do not check its return value before printing
the result.  In the case where the OID is zero-length, -EBADMSG was
being returned without anything being written to the buffer, resulting
in uninitialized stack memory being printed.  Fix this by writing
"(bad)" to the buffer in the cases where -EBADMSG is returned.

Fixes: 4f73175d03 ("X.509: Add utility functions to render OIDs as strings")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

2018-03-03 15:51:49 +00:00

179 lines

3.9 KiB

Raw Permalink Blame History