linux/fs/ecryptfs
Al Viro d6fc6d7915 do d_instantiate/unlock_new_inode combinations safely
commit 1e2e547a93 upstream.

For anything NFS-exported we do _not_ want to unlock new inode
before it has grown an alias; original set of fixes got the
ordering right, but missed the nasty complication in case of
lockdep being enabled - unlock_new_inode() does
	lockdep_annotate_inode_mutex_key(inode)
which can only be done before anyone gets a chance to touch
->i_mutex.  Unfortunately, flipping the order and doing
unlock_new_inode() before d_instantiate() opens a window when
mkdir can race with open-by-fhandle on a guessed fhandle, leading
to multiple aliases for a directory inode and all the breakage
that follows from that.

	Correct solution: a new primitive (d_instantiate_new())
combining these two in the right order - lockdep annotate, then
d_instantiate(), then the rest of unlock_new_inode().  All
combinations of d_instantiate() with unlock_new_inode() should
be converted to that.

Tested-by: Mike Marshall <hubcap@omnibond.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
[bwh: Backported to 3.16:
 - Drop changes in orangefs
 - Apply similar change to ext3
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2018-10-21 08:46:03 +01:00
..
crypto.c eCryptfs: Remove buggy and unnecessary write in file name decode routine 2015-01-15 10:44:18 +00:00
debug.c eCryptfs: update comment and debug statement 2007-10-16 09:43:11 -07:00
dentry.c eCryptfs: Invalidate dcache entries when lower i_nlink is zero 2015-09-28 10:21:45 +01:00
ecryptfs_kernel.h ecryptfs: fix dereference of NULL user_key_payload 2018-01-01 20:51:53 +00:00
file.c ecryptfs: don't allow mmap when the lower fs doesn't support it 2016-08-22 22:38:26 +01:00
inode.c do d_instantiate/unlock_new_inode combinations safely 2018-10-21 08:46:03 +01:00
Kconfig Minor code cleanups and new Kconfig option to disable /dev/ecryptfs 2013-03-07 12:47:24 -08:00
keystore.c ecryptfs: fix dereference of NULL user_key_payload 2018-01-01 20:51:53 +00:00
kthread.c eCryptfs: fix to use list_for_each_entry_safe() when delete items 2012-12-18 10:07:29 -06:00
main.c fs: limit filesystem stacking depth 2016-08-22 22:38:27 +01:00
Makefile eCryptfs: allow userspace messaging to be disabled 2013-03-03 23:59:59 -08:00
messaging.c eCryptfs: use after free in ecryptfs_release_messaging() 2018-02-13 18:42:16 +00:00
miscdev.c ecryptfs: close rmmod race 2013-04-09 14:08:16 -04:00
mmap.c eCryptfs: Avoid unnecessary disk read and data decryption during writing 2012-11-07 17:56:16 -08:00
read_write.c ecryptfs: don't open-code kernel_read() 2013-05-09 13:39:58 -04:00
super.c mm + fs: store shadow entries in page cache 2014-04-03 16:21:01 -07:00