kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-18 19:12:56 +00:00
Code Issues Releases Packages Activity
linux/include/net/sctp
History
Jason Gunthorpe 27d2d1dcad sctp: Fix mangled IPv4 addresses on a IPv6 listening socket 
commit 9302d7bb0c upstream.

sctp_v4_map_v6 was subtly writing and reading from members
of a union in a way the clobbered data it needed to read before
it read it.

Zeroing the v6 flowinfo overwrites the v4 sin_addr with 0, meaning
that every place that calls sctp_v4_map_v6 gets ::ffff:0.0.0.0 as the
result.

Reorder things to guarantee correct behaviour no matter what the
union layout is.

This impacts user space clients that open an IPv6 SCTP socket and
receive IPv4 connections. Prior to 299ee user space would see a
sockaddr with AF_INET and a correct address, after 299ee the sockaddr
is AF_INET6, but the address is wrong.

Fixes: 299ee123e1 (sctp: Fixup v4mapped behaviour to comply with Sock API)
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2018-06-16 22:21:29 +01:00
..
auth.h include/net/: Fix FSF address in file headers 2013-12-06 12:37:56 -05:00
checksum.h sctp: force the params with right types for sctp csum apis 2018-03-03 15:51:37 +00:00
command.h sctp: handle association restarts when the socket is closed. 2014-10-15 12:05:30 +02:00
constants.h include/net/: Fix FSF address in file headers 2013-12-06 12:37:56 -05:00
sctp.h sctp: Fix mangled IPv4 addresses on a IPv6 listening socket 2018-06-16 22:21:29 +01:00
sm.h net: sctp: fix skb_over_panic when receiving malformed ASCONF chunks 2014-11-13 11:48:26 +00:00
structs.h sctp: Fixup v4mapped behaviour to comply with Sock API 2018-02-13 18:42:22 +00:00
tsnmap.h sctp: Fix FSF address in file headers 2013-12-06 12:37:56 -05:00
ulpevent.h sctp: Fix FSF address in file headers 2013-12-06 12:37:56 -05:00
ulpqueue.h sctp: Fix FSF address in file headers 2013-12-06 12:37:56 -05:00