Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Rundong Ge 17bbfb3a56 net: dsa: slave: Don't propagate flag changes on down slave interfaces ... commit 17ab4f61b8 upstream. The unbalance of master's promiscuity or allmulti will happen after ifdown and ifup a slave interface which is in a bridge. When we ifdown a slave interface , both the 'dsa_slave_close' and 'dsa_slave_change_rx_flags' will clear the master's flags. The flags of master will be decrease twice. In the other hand, if we ifup the slave interface again, since the slave's flags were cleared the 'dsa_slave_open' won't set the master's flag, only 'dsa_slave_change_rx_flags' that triggered by 'br_add_if' will set the master's flags. The flags of master is increase once. Only propagating flag changes when a slave interface is up makes sure this does not happen. The 'vlan_dev_change_rx_flags' had the same problem and was fixed, and changes here follows that fix. Fixes: 91da11f870 ("net: Distributed Switch Architecture protocol support") Signed-off-by: Rundong Ge <rdong.ge@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>		History 2019-05-02 21:41:39 +01:00
..
dsa.c	net: dsa: Fix off-by-one in switch address parsing	2015-08-10 17:10:19 +01:00
dsa_priv.h	dsa: Move all definitions needed by drivers into <net/dsa.h>	2011-11-29 00:21:36 -05:00
Kconfig	dsa: Hide core config options; make drivers select what they need	2012-11-26 17:10:44 -05:00
Makefile	dsa: Move switch drivers to new directory drivers/net/dsa	2011-11-29 00:21:36 -05:00
slave.c	net: dsa: slave: Don't propagate flag changes on down slave interfaces	2019-05-02 21:41:39 +01:00
tag_dsa.c	dsa: Combine core and tagging code	2011-11-26 14:48:15 -05:00
tag_edsa.c	dsa: Combine core and tagging code	2011-11-26 14:48:15 -05:00
tag_trailer.c	dsa: Combine core and tagging code	2011-11-26 14:48:15 -05:00