Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Dan Carpenter 37d5d109db ACPI / sysfs: fix error code in get_status() ...

commit f18ebc211e upstream.

The problem with ornamental, do-nothing gotos is that they lead to
"forgot to set the error code" bugs.  We should be returning -EINVAL
here but we don't.  It leads to an uninitalized variable in
counter_show():

    drivers/acpi/sysfs.c:603 counter_show()
    error: uninitialized symbol 'status'.

Fixes: 1c8fce27e2 (ACPI: introduce drivers/acpi/sysfs.c)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

2016-08-22 22:37:54 +01:00

823 lines

21 KiB

Raw Permalink Blame History