Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Hangbin Liu 3b2cfcaa66 team: fix possible recursive locking when add slaves ... commit 925b0c841e upstream. If we add a bond device which is already the master of the team interface, we will hold the team->lock in team_add_slave() first and then request the lock in team_set_mac_address() again. The functions are called like: - team_add_slave() - team_port_add() - team_port_enter() - team_modeop_port_enter() - __set_port_dev_addr() - dev_set_mac_address() - bond_set_mac_address() - dev_set_mac_address() - team_set_mac_address Although team_upper_dev_link() would check the upper devices but it is called too late. Fix it by adding a checking before processing the slave. v2: Do not split the string in netdev_err() Fixes: 3d249d4ca7 ("net: introduce ethernet teaming device") Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> [bwh: Backported to 3.16: netlink doesn't support extack] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>		History 2019-08-13 12:39:13 +01:00
..
Kconfig	team: introduce random mode	2013-03-06 14:55:20 -05:00
Makefile	team: introduce random mode	2013-03-06 14:55:20 -05:00
team.c	team: fix possible recursive locking when add slaves	2019-08-13 12:39:13 +01:00
team_mode_activebackup.c	team: ab: set active port option as changed when port is leaving	2013-02-04 14:55:45 -05:00
team_mode_broadcast.c	team: introduce two default team_modeop functions and use them in modes	2013-03-06 14:55:20 -05:00
team_mode_loadbalance.c	team: lb: use sizeof(*fprog) in __fprog_create	2014-05-24 17:06:38 -04:00
team_mode_random.c	random32: add prandom_u32_max and convert open coded users	2014-01-21 23:17:20 -08:00
team_mode_roundrobin.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-06-19 16:49:39 -07:00