Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Eric Biggers a5ce3b463b KEYS: fix key refcount leak in keyctl_read_key() ...

commit 7fc0786d95 upstream.

In keyctl_read_key(), if key_permission() were to return an error code
other than EACCES, we would leak a the reference to the key.  This can't
actually happen currently because key_permission() can only return an
error code other than EACCES if security_key_permission() does, only
SELinux and Smack implement that hook, and neither can return an error
code other than EACCES.  But it should still be fixed, as it is a bug
waiting to happen.

Fixes: 29db919063 ("[PATCH] Keys: Add LSM hooks for key management [try #3]")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

2018-01-01 20:51:39 +00:00

1685 lines

41 KiB

Raw Permalink Blame History