linux/drivers/media/rc
James Hogan 7497d7d1b6 rc-main: Re-apply filter for no-op protocol change
commit 983c5bd26b upstream.

Since commit da6e162d6a ("[media] rc-core: simplify sysfs code"), when
the IR protocol is set using the sysfs interface to the same set of
protocols that are already set, store_protocols() does not refresh the
scancode filter with the new protocol, even if it has already called the
change_protocol() callback successfully. This results in the filter
being disabled in the hardware and not re-enabled until the filter is
set again using sysfs.

Fix in store_protocols() by still re-applying the filter whenever the
change_protocol() driver callback succeeded.

The problem can be reproduced with the img-ir driver by setting a
filter, and then setting the protocol to the same protocol that is
already set:
$ echo nec > protocols
$ echo 0xffff > filter_mask
$ echo nec > protocols

After this, messages which don't match the filter were still being
received.

Fixes: da6e162d6a ("[media] rc-core: simplify sysfs code")

Reported-by: Sifan Naeem <sifan.naeem@imgtec.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: David Härdeman <david@hardeman.nu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2015-03-06 14:52:51 -08:00
..
img-ir img-ir/hw: Fix potential deadlock stopping timer 2015-01-27 08:29:40 -08:00
keymaps media updates for v3.18-rc1 2014-10-10 22:04:49 -04:00
ati_remote.c [media] ati_remote: Use non-alomic __set_bit 2014-07-25 23:52:15 -03:00
ene_ir.c [media] ene_ir: use true/false for boolean vars 2014-09-03 17:59:20 -03:00
ene_ir.h [media] ene_ir: don't use pr_debug after all 2013-07-29 11:49:45 -03:00
fintek-cir.c [media] fintek-cir: just return 0 instead of using a var 2014-09-03 17:59:54 -03:00
fintek-cir.h [media] rc: Fir warnings on m68k arch 2013-11-08 09:45:37 -02:00
gpio-ir-recv.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
iguanair.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
imon.c [media] imon: fix other RC type protocol support 2014-11-03 10:56:51 -02:00
ir-hix5hd2.c [media] ir-hix5hd2 fix build warning 2014-11-03 10:47:05 -02:00
ir-jvc-decoder.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ir-lirc-codec.c media/rc: Send sync space information on the lirc device 2015-02-26 17:49:02 -08:00
ir-mce_kbd-decoder.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ir-nec-decoder.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ir-rc5-decoder.c [media] rc5-decoder: BZ#85721: Fix RC5-SZ decoding 2014-10-30 09:09:28 -02:00
ir-rc6-decoder.c [media] rc-core: fix toggle handling in the rc6 decoder 2014-11-21 15:57:47 -02:00
ir-rx51.c [media] ir-rx51: remove deprecated IRQF_DISABLED 2013-10-17 06:09:02 -03:00
ir-sanyo-decoder.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ir-sharp-decoder.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ir-sony-decoder.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ir-xmp-decoder.c [media] rc: Add support for decoding XMP protocol 2014-07-26 19:38:04 -03:00
ite-cir.c [media] ite-cir: just return 0 instead of using a var 2014-09-03 17:59:54 -03:00
ite-cir.h [media] ite-cir: 8709 needs to use pnp resource 2 2011-07-01 16:31:38 -03:00
Kconfig [media] rc: Introduce hix5hd2 IR transmitter driver 2014-09-23 17:03:57 -03:00
lirc_dev.c [media] lirc_dev: fix sparse warnings 2014-09-03 10:29:49 -03:00
Makefile [media] rc: Introduce hix5hd2 IR transmitter driver 2014-09-23 17:03:57 -03:00
mceusb.c [media] mceusb: fix usbdev leak 2014-09-23 16:13:38 -03:00
nuvoton-cir.c [media] nuvoton-cir: just return 0 instead of using a var 2014-09-03 17:59:55 -03:00
nuvoton-cir.h [media] nuvoton-cir: Don't touch PS/2 interrupts while initializing 2014-02-04 17:47:26 -02:00
rc-core-priv.h [media] rc: Add support for decoding XMP protocol 2014-07-26 19:38:04 -03:00
rc-ir-raw.c [media] rc-core: fix protocol_change regression in ir_raw_event_register 2014-10-30 09:09:28 -02:00
rc-loopback.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
rc-main.c rc-main: Re-apply filter for no-op protocol change 2015-03-06 14:52:51 -08:00
redrat3.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
st_rc.c [media] st_rc: fix address space casting 2014-09-26 06:47:53 -03:00
streamzap.c [media] rc-core: use USB API functions rather than constants 2014-09-22 17:27:01 -03:00
sunxi-cir.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
ttusbir.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00
winbond-cir.c [media] rc-core: remove protocol arrays 2014-07-25 19:10:43 -03:00