Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Ding Wang f078fd1dae mmc: card: Fixup request missing in mmc_blk_issue_rw_rq ... [ Upstream commit 29535f7b79 ] The current handler of MMC_BLK_CMD_ERR in mmc_blk_issue_rw_rq function may cause new coming request permanent missing when the ongoing request (previoulsy started) complete end. The problem scenario is as follows: (1) Request A is ongoing; (2) Request B arrived, and finally mmc_blk_issue_rw_rq() is called; (3) Request A encounters the MMC_BLK_CMD_ERR error; (4) In the error handling of MMC_BLK_CMD_ERR, suppose mmc_blk_cmd_err() end request A completed and return zero. Continue the error handling, suppose mmc_blk_reset() reset device success; (5) Continue the execution, while loop completed because variable ret is zero now; (6) Finally, mmc_blk_issue_rw_rq() return without processing request B. The process related to the missing request may wait that IO request complete forever, possibly crashing the application or hanging the system. Fix this issue by starting new request when reset success. Signed-off-by: Ding Wang <justin.wang@spreadtrum.com> Fixes: 67716327ee ("mmc: block: add eMMC hardware reset support") Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>		History 2015-08-04 14:35:17 -04:00
..
block.c	mmc: card: Fixup request missing in mmc_blk_issue_rw_rq	2015-08-04 14:35:17 -04:00
Kconfig	tty: Added a CONFIG_TTY option to allow removal of TTY	2013-01-18 16:15:27 -08:00
Makefile	mmc: Makefile: Fix EXTRA_CFLAGS assignment	2010-10-23 21:11:15 +08:00
mmc_test.c	mmc: mmc_test: replace strict_strtol() with kstrtol_from_user()	2013-08-24 23:19:05 -04:00
queue.c	mmc: card: Don't access RPMB partitions for normal read/write	2015-06-09 13:43:38 -04:00
queue.h	mmc: card: Don't access RPMB partitions for normal read/write	2015-06-09 13:43:38 -04:00
sdio_uart.c	mmc: Convert pr_warning to pr_warn	2014-09-24 10:13:09 +02:00