kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-22 19:14:51 +00:00
Code Issues Releases Packages Activity
linux/drivers/media/usb
History
Takashi Iwai 73db430b66 uvcvideo: Fix destruction order in uvc_delete() 
commit 2228d80dd0 upstream.

We've got a bug report at disconnecting a Webcam, where the kernel
spews warnings like below:
  WARNING: CPU: 0 PID: 8385 at ../fs/sysfs/group.c:219 sysfs_remove_group+0x87/0x90()
  sysfs group c0b2350c not found for kobject 'event3'
  CPU: 0 PID: 8385 Comm: queue2:src Not tainted 3.16.2-1.gdcee397-default #1
  Hardware name: ASUSTeK Computer INC. A7N8X-E/A7N8X-E, BIOS ASUS A7N8X-E Deluxe ACPI BIOS Rev 1013  11/12/2004
    c08d0705 ddc75cbc c0718c5b ddc75ccc c024b654 c08c6d44 ddc75ce8 000020c1
    c08d0705 000000db c03d1ec7 c03d1ec7 00000009 00000000 c0b2350c d62c9064
    ddc75cd4 c024b6a3 00000009 ddc75ccc c08c6d44 ddc75ce8 ddc75cfc c03d1ec7
  Call Trace:
    [<c0205ba6>] try_stack_unwind+0x156/0x170
    [<c02046f3>] dump_trace+0x53/0x180
    [<c0205c06>] show_trace_log_lvl+0x46/0x50
    [<c0204871>] show_stack_log_lvl+0x51/0xe0
    [<c0205c67>] show_stack+0x27/0x50
    [<c0718c5b>] dump_stack+0x3e/0x4e
    [<c024b654>] warn_slowpath_common+0x84/0xa0
    [<c024b6a3>] warn_slowpath_fmt+0x33/0x40
    [<c03d1ec7>] sysfs_remove_group+0x87/0x90
    [<c05a2c54>] device_del+0x34/0x180
    [<c05e3989>] evdev_disconnect+0x19/0x50
    [<c05e06fa>] __input_unregister_device+0x9a/0x140
    [<c05e0845>] input_unregister_device+0x45/0x80
    [<f854b1d6>] uvc_delete+0x26/0x110 [uvcvideo]
    [<f84d66f8>] v4l2_device_release+0x98/0xc0 [videodev]
    [<c05a25bb>] device_release+0x2b/0x90
    [<c04ad8bf>] kobject_cleanup+0x6f/0x1a0
    [<f84d5453>] v4l2_release+0x43/0x70 [videodev]
    [<c0372f31>] __fput+0xb1/0x1b0
    [<c02650c1>] task_work_run+0x91/0xb0
    [<c024d845>] do_exit+0x265/0x910
    [<c024df64>] do_group_exit+0x34/0xa0
    [<c025a76f>] get_signal_to_deliver+0x17f/0x590
    [<c0201b6a>] do_signal+0x3a/0x960
    [<c02024f7>] do_notify_resume+0x67/0x90
    [<c071ebb5>] work_notifysig+0x30/0x3b
    [<b7739e60>] 0xb7739e5f
   ---[ end trace b1e56095a485b631 ]---

The cause is that uvc_status_cleanup() is called after usb_put_*() in
uvc_delete().  usb_put_*() removes the sysfs parent and eventually
removes the children recursively, so the later device_del() can't find
its sysfs.  The fix is simply rearrange the call orders in
uvc_delete() so that the child is removed before the parent.

Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=897736
Reported-and-tested-by: Martin Pluskal <mpluskal@suse.com>

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2015-01-27 08:29:40 -08:00
..
airspy [media] airspy: enhance sample rate debug calculation precision 2014-09-21 16:42:33 -03:00
as102 [media] as102: fix endiannes casts 2014-09-26 06:47:52 -03:00
au0828 sound: simplify au0828 quirk table 2015-01-27 08:29:39 -08:00
b2c2 [media] drivers: media: usb: b2c2: use usb_*_coherent() instead of pci_*_consistent() in flexcop-usb.c 2013-10-17 11:26:41 -03:00
cpia2 [media] media: remove the setting of the flag V4L2_FL_USE_FH_PRIO 2014-07-04 16:14:59 -03:00
cx231xx [media] usb drivers: use %zu instead of %zd 2014-09-26 06:51:00 -03:00
dvb-usb af9005: fix kernel panic on init if compiled without IR 2015-01-27 08:29:39 -08:00
dvb-usb-v2 [media] anysee: make sure loading modules is const 2014-10-21 08:49:11 -02:00
em28xx [media] em28xx-input: NULL dereference on error 2014-10-24 09:28:12 -02:00
go7007 [media] go7007: fix sparse warnings 2014-09-03 09:33:24 -03:00
gspca media updates for v3.18-rc1 2014-10-10 22:04:49 -04:00
hackrf [media] hackrf: harmless off by one in debug code 2014-10-21 08:56:52 -02:00
hdpvr [media] hdpvr: reduce memory footprint when debugging 2014-09-23 16:13:36 -03:00
msi2500 [media] msi2500: remove unneeded spinlock irq flags initialization 2014-09-21 16:42:35 -03:00
pvrusb2 [media] media: pvrusb2: make logging code sane 2014-07-17 20:05:38 -03:00
pwc [media] pwc: fix sparse warning 2014-09-03 09:55:43 -03:00
s2255 [media] s2255drv: fix payload size for JPG, MJPEG 2014-11-21 15:46:25 -02:00
siano [media] usb drivers: use %zu instead of %zd 2014-09-26 06:51:00 -03:00
stk1160 [media] media: remove the setting of the flag V4L2_FL_USE_FH_PRIO 2014-07-04 16:14:59 -03:00
stkwebcam [media] v4l: Support extending the v4l2_pix_format structure 2014-07-17 12:44:47 -03:00
tlg2300 [media] v4l: Support extending the v4l2_pix_format structure 2014-07-17 12:44:47 -03:00
tm6000 [media] rc-core: rename dev->scanmask to dev->scancode_mask 2014-07-25 19:10:43 -03:00
ttusb-budget media: use pci_zalloc_consistent 2014-08-08 15:57:28 -07:00
ttusb-dec [media] ttusb-dec: buffer overflow in ioctl 2014-09-23 16:13:37 -03:00
usbtv [media] Media: USB: usbtv: Fixed all coding style issues in usbtv source files 2014-09-23 16:13:44 -03:00
usbvision [media] usbvision-video: two use after frees 2014-10-24 09:30:14 -02:00
uvc uvcvideo: Fix destruction order in uvc_delete() 2015-01-27 08:29:40 -08:00
zr364xx [media] v4l: Support extending the v4l2_pix_format structure 2014-07-17 12:44:47 -03:00
Kconfig [media] hackrf: HackRF SDR driver 2014-09-21 20:32:37 -03:00
Makefile [media] hackrf: HackRF SDR driver 2014-09-21 20:32:37 -03:00