linux/drivers/scsi/aacraid
Brian King 7192ae0240 scsi: aacraid: Fix command send race condition
commit 1ae948fa4f upstream.

This fixes a potential race condition observed on Power systems.

Several places throughout the aacraid driver call aac_fib_send or
similar to send a command to the aacraid adapter, then check the return
code to determine if the command was actually sent to the adapter, then
update the phase field in the scsi command scratch pad area to track
that the firmware now owns this command.  However, there is nothing that
ensures that by the time the aac_fib_send function returns and we go to
write to the scsi command, that the command hasn't already completed and
the scsi command has been freed.  This was causing random crashes in the
TCP stack which was tracked down to be caused by memory that had been a
struct request + scsi_cmnd being now used for an skbuff. Memory
poisoning was enabled in the kernel to debug this which showed that the
last owner of the memory that had been freed was aacraid and that it was
a struct request.  The memory that was corrupted was the exact data
pattern of AAC_OWNER_FIRMWARE and it was at the same offset that aacraid
writes, which is scsicmd->SCp.phase. The patch below resolves this
issue.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Tested-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
Reviewed-by: Dave Carroll <david.carroll@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2017-09-27 14:43:17 +02:00
..
aachba.c scsi: aacraid: Fix command send race condition 2017-09-27 14:43:17 +02:00
aacraid.h scsi: aacraid: Fix out of bounds in aac_get_name_resp 2017-08-16 20:01:31 -04:00
commctrl.c scsi: aacraid: Don't copy uninitialized stack memory to userspace 2017-06-26 15:01:03 -04:00
comminit.c scsi: aacraid: Remove reference to Series-9 2017-06-12 20:48:00 -04:00
commsup.c scsi: aacraid: Remove reference to Series-9 2017-06-12 20:48:00 -04:00
dpcsup.c scsi: aacraid: Update copyrights 2017-02-03 10:35:04 -05:00
linit.c scsi: aacraid: Remove reference to Series-9 2017-06-12 20:48:00 -04:00
Makefile [SCSI] aacraid: Add new code for PMC-Sierra's SRC based controller family 2011-03-23 11:36:58 -05:00
nark.c scsi: aacraid: Update copyrights 2017-02-03 10:35:04 -05:00
rkt.c scsi: aacraid: Update copyrights 2017-02-03 10:35:04 -05:00
rx.c scsi: aacraid: pci_alloc_consistent() failures on ARM64 2017-04-26 18:28:06 -04:00
sa.c scsi: aacraid: Update copyrights 2017-02-03 10:35:04 -05:00
src.c scsi: aacraid: Add reset debugging statements 2017-06-12 20:48:00 -04:00
TODO [SCSI] aacraid: Newer adapter communication iterface support 2005-10-28 11:41:53 -05:00