linux/drivers/media/rc
Sean Young e2204d254f media: Revert "[media] lirc_dev: remove superfluous get/put_device() calls"
commit a607f51e5a upstream.

This reverts commit 5be2b76a9c.

Only when the lirc device is freed, should we drop our reference to
rc_dev, else we the rc_dev is freed to early. If userspace has
a file descriptor open during unplug, it goes bang.

==================================================================
BUG: KASAN: use-after-free in __lock_acquire+0x7bb/0x1e10
Read of size 8 at addr ffff8801d7d61ed0 by task ir-rec/2609

-snip-
 mutex_lock_nested+0x1b/0x20
 ? mutex_lock_nested+0x1b/0x20
 rc_close.part.6+0x20/0x60 [rc_core]
 rc_close+0x13/0x20 [rc_core]
 lirc_dev_fop_close+0x62/0xd0 [lirc_dev]
 __fput+0x236/0x410
 ? fput+0xb0/0xb0
 ? do_raw_spin_trylock+0x110/0x110
 ? set_rq_offline.part.70+0xa0/0xa0
 ____fput+0xe/0x10
 task_work_run+0x116/0x180
 ? task_work_cancel+0x170/0x170
 ? _raw_spin_unlock+0x27/0x40
 ? switch_task_namespaces+0x5f/0x90
 do_exit+0x68b/0xe80

Fixes: 5be2b76a9c ("[media] lirc_dev: remove superfluous get/put_device() calls")
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2017-09-27 14:43:20 +02:00
..
img-ir [media] rc-core: img-ir - leave the internals of rc_dev alone 2017-06-06 09:08:50 -03:00
keymaps [media] rc: lirc keymap no longer makes any sense 2017-03-24 08:22:36 -03:00
ati_remote.c [media] rc-core: ati_remote - leave the internals of rc_dev alone 2017-06-06 09:08:10 -03:00
ene_ir.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
ene_ir.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fintek-cir.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
fintek-cir.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
gpio-ir-recv.c [media] gpio-ir: do not allow a timeout of 0 2017-03-24 08:21:48 -03:00
igorplugusb.c [media] mce_kbd: add encoder 2017-03-24 08:24:41 -03:00
iguanair.c [media] media drivers: annotate fall-through 2017-05-19 07:10:03 -03:00
imon.c [media] ir-core: fix gcc-7 warning on bool arithmetic 2017-05-19 07:04:45 -03:00
ir-hix5hd2.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
ir-jvc-decoder.c [media] rc: ir-jvc-decoder: Add encode capability 2017-01-30 13:52:57 -02:00
ir-lirc-codec.c media: lirc: LIRC_GET_REC_RESOLUTION should return microseconds 2017-07-26 05:46:42 -04:00
ir-mce_kbd-decoder.c [media] mce_kbd: add encoder 2017-03-24 08:24:41 -03:00
ir-nec-decoder.c [media] rc: ir-nec-decoder: Add encode capability 2017-01-30 13:52:28 -02:00
ir-rc5-decoder.c [media] rc: ir-rc5-decoder: Add encode capability 2017-01-30 13:50:52 -02:00
ir-rc6-decoder.c [media] rc: ir-rc6-decoder: Add encode capability 2017-01-30 13:51:34 -02:00
ir-rx51.c [media] ir-rx51: port to rc-core 2017-01-30 14:25:04 -02:00
ir-sanyo-decoder.c [media] rc: ir-sanyo-decoder: Add encode capability 2017-01-30 13:53:28 -02:00
ir-sharp-decoder.c [media] rc: ir-sharp-decoder: Add encode capability 2017-01-30 13:53:57 -02:00
ir-sony-decoder.c [media] rc: ir-sony-decoder: Add encode capability 2017-01-30 13:54:54 -02:00
ir-spi.c [media] ir-spi: Fix issues with lirc API 2017-06-07 09:40:55 -03:00
ir-xmp-decoder.c [media] media: rc: move check whether a protocol is enabled to the core 2015-11-19 11:39:17 -02:00
ite-cir.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
ite-cir.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
Kconfig [media] rc: fix breakage in "make menuconfig" for media_build 2017-06-06 08:56:31 -03:00
lirc_dev.c media: Revert "[media] lirc_dev: remove superfluous get/put_device() calls" 2017-09-27 14:43:20 +02:00
Makefile [media] rc: promote lirc_sir out of staging 2017-04-05 14:50:57 -03:00
mceusb.c [media] mceusb: drop redundant urb reinitialisation 2017-06-07 09:39:52 -03:00
meson-ir.c [media] rc: meson-ir: switch config to NEC decoding on shutdown 2017-06-06 08:56:32 -03:00
mtk-cir.c [media] rc: add driver for IR remote receiver on MT7623 SoC 2017-01-31 07:25:30 -02:00
nuvoton-cir.c [media] rc: nuvoton: fix deadlock in nvt_write_wakeup_codes 2017-03-03 07:06:57 -03:00
nuvoton-cir.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
rc-core-priv.h [media] rc-core: cleanup rc_register_device 2017-06-13 13:53:50 -03:00
rc-ir-raw.c [media] rc-core: cleanup rc_register_device 2017-06-13 13:53:50 -03:00
rc-loopback.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
rc-main.c [media] rc-core: cleanup rc_register_device pt2 2017-06-13 13:55:01 -03:00
redrat3.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
serial_ir.c Annotation of module parameters that specify device settings 2017-05-10 19:13:03 -07:00
sir_ir.c [media] sir_ir: annotate hardware config module parameters 2017-06-13 13:49:24 -03:00
st_rc.c [media] st_rc: simplify optional reset handling 2017-03-24 08:29:27 -03:00
streamzap.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
sunxi-cir.c [media] rc: sunxi-cir: simplify optional reset handling 2017-03-24 08:30:03 -03:00
ttusbir.c [media] rc-main: assign driver type during allocation 2017-01-30 13:59:57 -02:00
winbond-cir.c [media] winbond: allow timeout to be set 2017-03-24 08:21:17 -03:00