linux/drivers/staging/vboxvideo
Hans de Goede ccc04bde3a staging: vboxvideo: Fix reporting invalid suggested-offset-properties
commit ce10d7b4e8 upstream.

The x and y hints receives from the host are unsigned 32 bit integers and
they get set to -1 (0xffffffff) when invalid. Before this commit the
vboxvideo driver was storing them in an u16 causing the -1 to be truncated
to 65535 which, once reported to userspace, was breaking gnome 3.26+
in Wayland mode.

This commit stores the host values in 32 bit variables, removing the
truncation and checks for -1, replacing it with 0 as -1 is not a valid
suggested-offset-property value. Likewise the properties are now
initialized to 0 instead of -1, since -1 is not a valid value.
This fixes gnome 3.26+ in Wayland mode not working with the vboxvideo
driver.

Reported-by: Gianfranco Costamagna <locutusofborg@debian.org>
Cc: Michael Thayer <michael.thayer@oracle.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2017-11-21 09:49:24 +01:00
..
hgsmi_base.c staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
hgsmi_ch_setup.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
hgsmi_channels.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
hgsmi_defs.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
Kconfig staging: vboxvideo: select DRM_TTM 2017-08-18 15:57:15 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
modesetting.c staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
TODO staging: vboxvideo: Add dri-devel to lists of email-addresses to send patches to 2017-08-18 15:57:15 -07:00
vbox_drv.c Staging/IIO driver updates for 4.14-rc1 2017-09-05 10:36:26 -07:00
vbox_drv.h staging: vboxvideo: Fix reporting invalid suggested-offset-properties 2017-11-21 09:49:24 +01:00
vbox_err.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
vbox_fb.c staging: vboxvideo: Use CONFIG_DRM_KMS_FB_HELPER to check for fbdefio availability 2017-08-31 18:29:32 +02:00
vbox_hgsmi.c staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
vbox_irq.c staging: vboxvideo: Fix reporting invalid suggested-offset-properties 2017-11-21 09:49:24 +01:00
vbox_main.c staging: vboxvideo: switch to drm_*{get,put} helpers 2017-08-18 15:57:15 -07:00
vbox_mode.c staging: vboxvideo: Fix reporting invalid suggested-offset-properties 2017-11-21 09:49:24 +01:00
vbox_prime.c staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
vbox_ttm.c staging: vboxvideo: make a couple of symbols static 2017-07-28 17:05:40 -07:00
vboxvideo.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
vboxvideo_guest.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
vboxvideo_vbe.h staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00
vbva_base.c staging: vboxvideo: Add vboxvideo to drivers/staging 2017-07-17 13:04:07 +02:00