Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

NeilBrown 423f04d63c md/raid1: extend spinlock to protect raid1_end_read_request against inconsistencies ...

raid1_end_read_request() assumes that the In_sync bits are consistent
with the ->degaded count.
raid1_spare_active updates the In_sync bit before the ->degraded count
and so exposes an inconsistency, as does error()
So extend the spinlock in raid1_spare_active() and error() to hide those
inconsistencies.

This should probably be part of
  Commit: 34cab6f420 ("md/raid1: fix test for 'was read error from
  last working device'.")
as it addresses the same issue.  It fixes the same bug and should go
to -stable for same reasons.

Fixes: 76073054c9 ("md/raid1: clean up read_balance.")
Cc: stable@vger.kernel.org (v3.0+)
Signed-off-by: NeilBrown <neilb@suse.com>

2015-08-03 12:29:42 +10:00

3200 lines

87 KiB

Raw Permalink Blame History