linux/drivers/video
Vlad Tsyrklevich f134f703dd omap2fb: Fix stack memory disclosure
commit a01421e448 upstream.

Using [1] for static analysis I found that the OMAPFB_QUERY_PLANE,
OMAPFB_GET_COLOR_KEY, OMAPFB_GET_DISPLAY_INFO, and OMAPFB_GET_VRAM_INFO
cases could all leak uninitialized stack memory--either due to
uninitialized padding or 'reserved' fields.

Fix them by clearing the shared union used to store copied out data.

[1] https://github.com/vlad902/kernel-uninitialized-memory-checker

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Reviewed-by: Kees Cook <keescook@chromium.org>
Fixes: b39a982dde ("OMAP: DSS2: omapfb driver")
Cc: security@kernel.org
[b.zolnierkie: prefix patch subject with "omap2fb: "]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2019-01-22 21:09:55 +01:00
..
backlight backlight: pwm_bl: Fix brightness levels for non-DT case. 2018-12-10 15:37:47 +00:00
console dummycon: Stop exporting dummycon_[un]register_output_notifier 2018-08-10 17:23:02 +02:00
fbdev omap2fb: Fix stack memory disclosure 2019-01-22 21:09:55 +01:00
logo video/logo: remove obsolete logo files 2018-03-26 15:56:42 +02:00
display_timing.c video: add display_timing and videomode 2013-01-24 09:03:04 +01:00
hdmi.c media: hdmi.h: rename ADOBE_RGB to OPRGB and ADOBE_YCC to OPYCC 2018-09-24 09:28:41 -04:00
Kconfig fbdev changes for v4.17: 2018-04-10 10:20:00 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
of_display_timing.c fbdev: Convert to using %pOFn instead of device_node.name 2018-10-08 12:57:36 +02:00
of_videomode.c video: fbdev: Convert to using %pOF instead of full_name 2017-08-07 17:22:13 +02:00
vgastate.c Video: vgastate: fixed a spacing coding style 2018-10-08 12:57:35 +02:00
videomode.c videomode: videomode_from_timing work 2013-03-21 14:34:33 +02:00