Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Willem de Bruijn 3cae5ef1f3 tap: call skb_probe_transport_header after setting skb->dev ...

[ Upstream commit 8c76e77f90 ]

The BPF flow dissector expects either skb->sk or skb->dev set on
all skbs. Delay flow dissection until after skb->dev is set.

This requires calling from within an rcu read-side critical section.
That is fine, see also the call from tun_xdp_one.

Fixes: d0e13a1488 ("flow_dissector: lookup netns by skb->sk if skb->dev is NULL")
Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-01-09 17:45:50 +01:00

1382 lines

30 KiB

Raw Permalink Blame History