kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-11-13 07:31:07 +00:00
Code Issues Releases Packages Activity
linux/drivers/scsi/megaraid
History
Arnd Bergmann 5b6e810f35 megaraid_sas: add missing curly braces in ioctl handler 
commit 3deb9438d3 upstream.

gcc-6 found a dubious indentation in the megasas_mgmt_fw_ioctl
function:

drivers/scsi/megaraid/megaraid_sas_base.c: In function 'megasas_mgmt_fw_ioctl':
drivers/scsi/megaraid/megaraid_sas_base.c:6658:4: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
    kbuff_arr[i] = NULL;
    ^~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_base.c:6653:3: note: ...this 'if' clause, but it is not
   if (kbuff_arr[i])
   ^~

The code is actually correct, as there is no downside in clearing a NULL
pointer again.

This clarifies the code and avoids the warning by adding extra curly
braces.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 90dc9d98f0 ("megaraid_sas : MFI MPT linked list corruption fix")
Reviewed-by: Hannes Reinecke <hare@suse.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2016-05-04 14:48:54 -07:00
..
Kconfig.megaraid [SCSI] megaraid_{mbox,mm} : remove PCI Id overlaping between megaraid_legacy and megaraid_{mbox,mm} 2005-12-13 18:10:56 -07:00
Makefile [SCSI] megaraid_sas: Add 9565/9285 specific code 2010-12-22 23:26:53 -06:00
mbox_defs.h Fix common misspellings 2011-03-31 11:26:23 -03:00
mega_common.h scsi: use 64-bit LUNs 2014-07-17 22:07:37 +02:00
megaraid_ioctl.h Convert asm/semaphore.h users to linux/semaphore.h 2008-04-18 22:22:54 -04:00
megaraid_mbox.c scsi: drop reason argument from ->change_queue_depth 2014-11-24 14:45:27 +01:00
megaraid_mbox.h [SCSI] megaraid_mbox: fix Dell CERC firmware problem 2008-04-29 19:34:07 -05:00
megaraid_mm.c [SCSI] megaraid: missing bounds check in mimd_to_kioc() 2014-03-15 10:19:00 -07:00
megaraid_mm.h [SCSI] MegaRAID driver management char device moved to misc 2008-02-11 10:20:53 -06:00
megaraid_sas.h megaraid_sas: Make tape drives visible on PERC5 controllers 2015-11-09 11:06:12 -05:00
megaraid_sas_base.c megaraid_sas: add missing curly braces in ioctl handler 2016-05-04 14:48:54 -07:00
megaraid_sas_fp.c megaraid_sas : Remove debug print from function megasas_update_span_set 2015-11-02 22:58:29 -05:00
megaraid_sas_fusion.c megaraid_sas: Fix sparse warning 2015-11-09 11:07:16 -05:00
megaraid_sas_fusion.h megaraid_sas: Remove PCI id checks 2015-10-29 03:14:54 -04:00