Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Miklos Szeredi 8e510cd921 vfs: fix deadlock in file_remove_privs() on overlayfs ...

commit c1892c3776 upstream.

file_remove_privs() is called with inode lock on file_inode(), which
proceeds to calling notify_change() on file->f_path.dentry.  Which triggers
the WARN_ON_ONCE(!inode_is_locked(inode)) in addition to deadlocking later
when ovl_setattr tries to lock the underlying inode again.

Fix this mess by not mixing the layers, but doing everything on underlying
dentry/inode.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 07a2daab49 ("ovl: Copy up underlying inode's ->i_mode to overlay inode")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2016-08-10 11:49:30 +02:00

2030 lines

53 KiB

Raw Permalink Blame History