Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Nicolai Stange 75f0b68b75 debugfs: open_proxy_open(): avoid double fops release ... Debugfs' open_proxy_open(), the ->open() installed at all inodes created through debugfs_create_file_unsafe(), - grabs a reference to the original file_operations instance passed to debugfs_create_file_unsafe() via fops_get(), - installs it at the file's ->f_op by means of replace_fops() - and calls fops_put() on it. Since the semantics of replace_fops() are such that the reference's ownership is transferred, the subsequent fops_put() will result in a double release when the file is eventually closed. Currently, this is not an issue since fops_put() basically does a module_put() on the file_operations' ->owner only and there don't exist any modules calling debugfs_create_file_unsafe() yet. This is expected to change in the future though, c.f. commit c646880814 ("debugfs: add support for self-protecting attribute file fops"). Remove the call to fops_put() from open_proxy_open(). Fixes: 9fd4dcece4 ("debugfs: prevent access to possibly dead file_operations at file open") Signed-off-by: Nicolai Stange <nicstange@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2016-06-15 04:56:35 -07:00
..
file.c	debugfs: open_proxy_open(): avoid double fops release	2016-06-15 04:56:35 -07:00
inode.c	Merge 4.6-rc4 into driver-core-next	2016-04-19 04:28:28 +09:00
internal.h	debugfs: prevent access to removed files' private data	2016-04-12 14:14:21 -07:00
Makefile	Linux-2.6.12-rc2	2005-04-16 15:20:36 -07:00