kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-16 22:39:48 +00:00
Code Issues Releases Packages Activity
linux/drivers/net/hamradio
History
Ralf Baechle 008798746e NET: mkiss: Fix panic 
[ Upstream commit 7ba1b68903 ]

If a USB-to-serial adapter is unplugged, the driver re-initializes, with
dev->hard_header_len and dev->addr_len set to zero, instead of the correct
values.  If then a packet is sent through the half-dead interface, the
kernel will panic due to running out of headroom in the skb when pushing
for the AX.25 headers resulting in this panic:

[<c0595468>] (skb_panic) from [<c0401f70>] (skb_push+0x4c/0x50)
[<c0401f70>] (skb_push) from [<bf0bdad4>] (ax25_hard_header+0x34/0xf4 [ax25])
[<bf0bdad4>] (ax25_hard_header [ax25]) from [<bf0d05d4>] (ax_header+0x38/0x40 [mkiss])
[<bf0d05d4>] (ax_header [mkiss]) from [<c041b584>] (neigh_compat_output+0x8c/0xd8)
[<c041b584>] (neigh_compat_output) from [<c043e7a8>] (ip_finish_output+0x2a0/0x914)
[<c043e7a8>] (ip_finish_output) from [<c043f948>] (ip_output+0xd8/0xf0)
[<c043f948>] (ip_output) from [<c043f04c>] (ip_local_out_sk+0x44/0x48)

This patch makes mkiss behave like the 6pack driver. 6pack does not
panic.  In 6pack.c sp_setup() (same function name here) the values for
dev->hard_header_len and dev->addr_len are set to the same values as in
my mkiss patch.

[ralf@linux-mips.org: Massages original submission to conform to the usual
standards for patch submissions.]

Signed-off-by: Thomas Osterried <thomas@osterried.de>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2017-06-17 06:41:50 +02:00
..
6pack.c 6pack: fix buffer length mishandling 2016-09-20 22:51:30 -04:00
baycom_epp.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2016-05-17 16:26:30 -07:00
baycom_par.c hamradio: baycom: fix old-style declaration 2016-06-16 22:06:30 -07:00
baycom_ser_fdx.c net: hamradio: baycom_ser_fdx: Replace timeval with timespec64 2016-02-11 09:54:54 -05:00
baycom_ser_hdx.c hamradio: baycom: remove deprecated IRQF_DISABLED 2013-09-30 15:08:13 -04:00
bpqether.c hamradio: use IS_ENABLED() instead of checking for built-in or module 2016-09-12 20:27:59 -07:00
dmascc.c dmascc: Return correct error codes 2016-02-16 15:32:34 -05:00
hdlcdrv.c drivers: net: use NETDEV_TX_OK instead of NETDEV_TX_LOCKED 2016-04-26 15:53:05 -04:00
Kconfig tty: Added a CONFIG_TTY option to allow removal of TTY 2013-01-18 16:15:27 -08:00
Makefile Fix common misspellings 2011-03-31 11:26:23 -03:00
mkiss.c NET: mkiss: Fix panic 2017-06-17 06:41:50 +02:00
scc.c treewide: replace dev->trans_start update with helper 2016-05-04 14:16:49 -04:00
yam.c treewide: replace dev->trans_start update with helper 2016-05-04 14:16:49 -04:00
z8530.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00