linux/drivers/crypto/caam
Horia Geantă 80495c7084 crypto: caam - fix signals handling
commit 7459e1d25f upstream.

Driver does not properly handle the case when signals interrupt
wait_for_completion_interruptible():
-it does not check for return value
-completion structure is allocated on stack; in case a signal interrupts
the sleep, it will go out of scope, causing the worker thread
(caam_jr_dequeue) to fail when it accesses it

wait_for_completion_interruptible() is replaced with uninterruptable
wait_for_completion().
We choose to block all signals while waiting for I/O (device executing
the split key generation job descriptor) since the alternative - in
order to have a deterministic device state - would be to flush the job
ring (aborting *all* in-progress jobs).

Fixes: 045e36780f ("crypto: caam - ahash hmac support")
Fixes: 4c1ec1f930 ("crypto: caam - refactor key_gen, sg")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2017-07-21 07:42:23 +02:00
..
caamalg.c crypto: caam - properly set IV after {en,de}crypt 2017-07-21 07:42:23 +02:00
caamhash.c crypto: caam - fix signals handling 2017-07-21 07:42:23 +02:00
caampkc.c crypto: caam - fix invalid dereference in caam_rsa_init_tfm() 2017-04-18 07:11:49 +02:00
caampkc.h crypto: caam - add support for RSA algorithm 2016-07-05 23:05:24 +08:00
caamrng.c crypto: caam - Use the preferred style for memory allocations 2015-08-24 22:07:42 +08:00
compat.h crypto: caam - add support for RSA algorithm 2016-07-05 23:05:24 +08:00
ctrl.c crypto: caam - fix RNG deinstantiation error checking 2017-04-18 07:11:49 +02:00
ctrl.h crypto: caam - fix ERA retrieval function 2014-02-09 09:59:27 +08:00
desc.h crypto: caam - treat SGT address pointer as u64 2016-10-02 22:33:45 +08:00
desc_constr.h crypto: caam - fix rfc3686(ctr(aes)) IV load 2016-09-07 21:08:28 +08:00
error.c crypto: caam - don't emit ICV check failures to dmesg 2015-01-26 11:34:23 +11:00
error.h crypto: caam - Contain caam_jr_strstatus() ugliness 2014-05-08 21:58:06 +08:00
intern.h crypto: caam - get rid of tasklet 2016-08-09 18:47:28 +08:00
jr.c crypto: caam - Unmap region obtained by of_iomap 2016-10-02 22:33:43 +08:00
jr.h crypto: caam - Add API's to allocate/free Job Rings 2013-10-30 12:02:57 +08:00
Kconfig crypto: caam - add support for RSA algorithm 2016-07-05 23:05:24 +08:00
key_gen.c crypto: caam - fix signals handling 2017-07-21 07:42:23 +02:00
key_gen.h crypto: caam - change key gen functions to return signed int 2013-04-25 21:01:43 +08:00
Makefile crypto: caam - add support for RSA algorithm 2016-07-05 23:05:24 +08:00
pdb.h crypto: caam - add support for RSA algorithm 2016-07-05 23:05:24 +08:00
pkc_desc.c crypto: caam - add support for RSA algorithm 2016-07-05 23:05:24 +08:00
regs.h crypto: caam - treat SGT address pointer as u64 2016-10-02 22:33:45 +08:00
sg_sw_sec4.h crypto: caam - treat SGT address pointer as u64 2016-10-02 22:33:45 +08:00