kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-18 19:12:56 +00:00
Code Issues Releases Packages Activity
linux/drivers/isdn
History
Meng Xu 93eef2172d isdn/i4l: fetch the ppp_write buffer in one shot 
[ Upstream commit 02388bf87f ]

In isdn_ppp_write(), the header (i.e., protobuf) of the buffer is
fetched twice from userspace. The first fetch is used to peek at the
protocol of the message and reset the huptimer if necessary; while the
second fetch copies in the whole buffer. However, given that buf resides
in userspace memory, a user process can race to change its memory content
across fetches. By doing so, we can either avoid resetting the huptimer
for any type of packets (by first setting proto to PPP_LCP and later
change to the actual type) or force resetting the huptimer for LCP
packets.

This patch changes this double-fetch behavior into two single fetches
decided by condition (lp->isdn_device < 0 || lp->isdn_channel <0).
A more detailed discussion can be found at
https://marc.info/?l=linux-kernel&m=150586376926123&w=2

Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2017-10-12 11:51:21 +02:00
..
capi isdn/capi: Use setup_timer 2015-05-31 21:36:37 -07:00
divert isdn: divert, hysdn: fix interruptible_sleep_on race 2014-02-26 16:06:13 -05:00
gigaset isdn/gigaset: fix NULL-deref at probe 2017-03-26 13:05:58 +02:00
hardware ISDN: eicon: silence misleading array-bounds warning 2017-02-01 08:33:06 +01:00
hisax isdn: hisax: set error code on failure 2016-12-05 15:03:42 -05:00
hysdn treewide: replace dev->trans_start update with helper 2016-05-04 14:16:49 -04:00
i4l isdn/i4l: fetch the ppp_write buffer in one shot 2017-10-12 11:51:21 +02:00
isdnloop drivers: isdn: isdnloop: isdnloop.c: Remove parenthesis around return values, as specified in CodingStyle. 2015-02-05 15:40:23 -08:00
mISDN mISDN: Fixing missing validation in base_sock_bind() 2016-04-13 23:00:50 -04:00
Kconfig tty: Added a CONFIG_TTY option to allow removal of TTY 2013-01-18 16:15:27 -08:00
Makefile isdn: i4l: move active-isdn drivers to staging 2016-03-05 15:00:38 -08:00