linux/drivers/soundwire
Richard Fitzgerald 96e9297738 soundwire: stream: Fix test for DP prepare complete
[ Upstream commit 3d3e88e336 ]

In sdw_prep_deprep_slave_ports(), after the wait_for_completion()
the DP prepare status register is read. If this indicates that the
port is now prepared, the code should continue with the port setup.
It is irrelevant whether the wait_for_completion() timed out if the
port is now ready.

The previous implementation would always fail if the
wait_for_completion() timed out, even if the port was reporting
successful prepare.

This patch also fixes a minor bug where the return from sdw_read()
was not checked for error - any error code with LSBits clear could
be misinterpreted as a successful port prepare.

Fixes: 79df15b7d3 ("soundwire: Add helpers for ports operations")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210618144745.30629-1-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2021-07-14 17:07:42 +02:00
..
bus.c soundwire: export sdw_compare_devid, sdw_extract_slave_id and sdw_slave_add 2021-03-30 22:55:07 +05:30
bus.h soundwire: Intel: introduce DMI quirks for HP Spectre x360 Convertible 2021-03-22 17:33:10 +05:30
bus_type.c soundwire: bus: use correct driver name in error messages 2021-03-30 11:51:42 +05:30
cadence_master.c soundwire: cadence: only prepare attached devices on clock stop 2021-03-30 14:36:11 +05:30
cadence_master.h soundwire: cadence: fix race condition between suspend and Slave device alerts 2020-09-09 13:14:42 +05:30
debugfs.c soundwire: Revert "soundwire: debugfs: use controller id instead of link_id" 2021-02-06 15:52:21 +05:30
dmi-quirks.c soundwire: Intel: add DMI quirk for Dell SKU 0A3E 2021-03-22 17:33:10 +05:30
generic_bandwidth_allocation.c soundwire: generic_allocation: fix confusion between group and packing 2021-03-30 14:36:11 +05:30
intel.c soundwire: intel: remove useless readl 2021-03-30 11:51:43 +05:30
intel.h ALSA: hda: move Intel SoundWire ACPI scan to dedicated module 2021-03-02 15:33:00 +01:00
intel_init.c soundwire: intel_init: test link->cdns 2021-04-06 10:26:44 +05:30
Kconfig soundwire: Add generic bandwidth allocation algorithm 2020-09-18 17:48:51 +05:30
Makefile soundwire: Intel: introduce DMI quirks for HP Spectre x360 Convertible 2021-03-22 17:33:10 +05:30
master.c soundwire: master: use pm_runtime_set_active() on add 2020-12-02 12:49:34 +05:30
mipi_disco.c soundwire: fix port_ready[] dynamic allocation in mipi_disco 2020-09-03 16:02:29 +05:30
qcom.c soundwire: qcom: fix handling of qcom,ports-block-pack-mode 2021-05-13 11:14:13 +05:30
slave.c soundwire: export sdw_compare_devid, sdw_extract_slave_id and sdw_slave_add 2021-03-30 22:55:07 +05:30
stream.c soundwire: stream: Fix test for DP prepare complete 2021-07-14 17:07:42 +02:00
sysfs_local.h soundwire: sysfs: add slave status and device number before probe 2020-09-28 11:17:43 +05:30
sysfs_slave.c soundwire: sysfs: Constify static struct attribute_group 2021-01-19 20:21:20 +05:30
sysfs_slave_dpn.c soundwire: Fix DEBUG_LOCKS_WARN_ON for uninitialized attribute 2020-11-24 14:08:51 +05:30