Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Nick Desaulniers 132a5ae413 bpf: Fix BTF_ID symbol generation collision in tools/ ... commit c0bb9fb0e5 upstream. Marcus and Satya reported an issue where BTF_ID macro generates same symbol in separate objects and that breaks final vmlinux link. ld.lld: error: ld-temp.o <inline asm>:14577:1: symbol '__BTF_ID__struct__cgroup__624' is already defined This can be triggered under specific configs when __COUNTER__ happens to be the same for the same symbol in two different translation units, which is already quite unlikely to happen. Add __LINE__ number suffix to make BTF_ID symbol more unique, which is not a complete fix, but it would help for now and meanwhile we can work on better solution as suggested by Andrii. Cc: stable@vger.kernel.org Reported-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com> Reported-by: Marcus Seyfarth <m.seyfarth@gmail.com> Closes: https://github.com/ClangBuiltLinux/linux/issues/1913 Debugged-by: Nathan Chancellor <nathan@kernel.org> Co-developed-by: Jiri Olsa <jolsa@kernel.org> Link: https://lore.kernel.org/bpf/CAEf4Bzb5KQ2_LmhN769ifMeSJaWfebccUasQOfQKaOd0nQ51tw@mail.gmail.com/ Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Link: https://lore.kernel.org/r/20230915-bpf_collision-v3-2-263fc519c21f@google.com Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2023-10-06 13:18:23 +02:00
..
asm	tools arch: Update arch/x86/lib/mem{cpy,set}_64.S copies used in 'perf bench mem memcpy'	2021-05-10 09:01:00 -03:00
asm-generic	x86/insn: Use get_unaligned() instead of memcpy()	2021-11-18 19:16:30 +01:00
linux	bpf: Fix BTF_ID symbol generation collision in tools/	2023-10-06 13:18:23 +02:00
nolibc	tools/nolibc: fix the O_* fcntl/open macro definitions for riscv	2023-01-18 11:48:56 +01:00
tools	tools include: add dis-asm-compat.h to handle version differences	2023-03-17 08:49:04 +01:00
trace/events	tools/lib/lockdep: Remove private kernel headers	2017-06-05 09:28:14 +02:00
uapi	bpf: Clarify error expectations from bpf_clone_redirect	2023-10-06 13:18:17 +02:00
vdso	tools headers: Synchronize linux/bits.h with the kernel sources	2020-04-14 11:40:05 -03:00