Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Kim Phillips 7535ec350a crypto: ccp - Fix null pointer dereference in __sev_platform_shutdown_locked ... commit ccb88e9549 upstream. The SEV platform device can be shutdown with a null psp_master, e.g., using DEBUG_TEST_DRIVER_REMOVE. Found using KASAN: [ 137.148210] ccp 0000:23:00.1: enabling device (0000 -> 0002) [ 137.162647] ccp 0000:23:00.1: no command queues available [ 137.170598] ccp 0000:23:00.1: sev enabled [ 137.174645] ccp 0000:23:00.1: psp enabled [ 137.178890] general protection fault, probably for non-canonical address 0xdffffc000000001e: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN NOPTI [ 137.182693] KASAN: null-ptr-deref in range [0x00000000000000f0-0x00000000000000f7] [ 137.182693] CPU: 93 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc1+ #311 [ 137.182693] RIP: 0010:__sev_platform_shutdown_locked+0x51/0x180 [ 137.182693] Code: 08 80 3c 08 00 0f 85 0e 01 00 00 48 8b 1d 67 b6 01 08 48 b8 00 00 00 00 00 fc ff df 48 8d bb f0 00 00 00 48 89 f9 48 c1 e9 03 <80> 3c 01 00 0f 85 fe 00 00 00 48 8b 9b f0 00 00 00 48 85 db 74 2c [ 137.182693] RSP: 0018:ffffc900000cf9b0 EFLAGS: 00010216 [ 137.182693] RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 000000000000001e [ 137.182693] RDX: 0000000000000000 RSI: 0000000000000008 RDI: 00000000000000f0 [ 137.182693] RBP: ffffc900000cf9c8 R08: 0000000000000000 R09: fffffbfff58f5a66 [ 137.182693] R10: ffffc900000cf9c8 R11: ffffffffac7ad32f R12: ffff8881e5052c28 [ 137.182693] R13: ffff8881e5052c28 R14: ffff8881758e43e8 R15: ffffffffac64abf8 [ 137.182693] FS: 0000000000000000(0000) GS:ffff889de7000000(0000) knlGS:0000000000000000 [ 137.182693] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 137.182693] CR2: 0000000000000000 CR3: 0000001cf7c7e000 CR4: 0000000000350ef0 [ 137.182693] Call Trace: [ 137.182693] <TASK> [ 137.182693] ? show_regs+0x6c/0x80 [ 137.182693] ? __die_body+0x24/0x70 [ 137.182693] ? die_addr+0x4b/0x80 [ 137.182693] ? exc_general_protection+0x126/0x230 [ 137.182693] ? asm_exc_general_protection+0x2b/0x30 [ 137.182693] ? __sev_platform_shutdown_locked+0x51/0x180 [ 137.182693] sev_firmware_shutdown.isra.0+0x1e/0x80 [ 137.182693] sev_dev_destroy+0x49/0x100 [ 137.182693] psp_dev_destroy+0x47/0xb0 [ 137.182693] sp_destroy+0xbb/0x240 [ 137.182693] sp_pci_remove+0x45/0x60 [ 137.182693] pci_device_remove+0xaa/0x1d0 [ 137.182693] device_remove+0xc7/0x170 [ 137.182693] really_probe+0x374/0xbe0 [ 137.182693] ? srso_return_thunk+0x5/0x5f [ 137.182693] __driver_probe_device+0x199/0x460 [ 137.182693] driver_probe_device+0x4e/0xd0 [ 137.182693] __driver_attach+0x191/0x3d0 [ 137.182693] ? __pfx___driver_attach+0x10/0x10 [ 137.182693] bus_for_each_dev+0x100/0x190 [ 137.182693] ? __pfx_bus_for_each_dev+0x10/0x10 [ 137.182693] ? __kasan_check_read+0x15/0x20 [ 137.182693] ? srso_return_thunk+0x5/0x5f [ 137.182693] ? _raw_spin_unlock+0x27/0x50 [ 137.182693] driver_attach+0x41/0x60 [ 137.182693] bus_add_driver+0x2a8/0x580 [ 137.182693] driver_register+0x141/0x480 [ 137.182693] __pci_register_driver+0x1d6/0x2a0 [ 137.182693] ? srso_return_thunk+0x5/0x5f [ 137.182693] ? esrt_sysfs_init+0x1cd/0x5d0 [ 137.182693] ? __pfx_sp_mod_init+0x10/0x10 [ 137.182693] sp_pci_init+0x22/0x30 [ 137.182693] sp_mod_init+0x14/0x30 [ 137.182693] ? __pfx_sp_mod_init+0x10/0x10 [ 137.182693] do_one_initcall+0xd1/0x470 [ 137.182693] ? __pfx_do_one_initcall+0x10/0x10 [ 137.182693] ? parameq+0x80/0xf0 [ 137.182693] ? srso_return_thunk+0x5/0x5f [ 137.182693] ? __kmalloc+0x3b0/0x4e0 [ 137.182693] ? kernel_init_freeable+0x92d/0x1050 [ 137.182693] ? kasan_populate_vmalloc_pte+0x171/0x190 [ 137.182693] ? srso_return_thunk+0x5/0x5f [ 137.182693] kernel_init_freeable+0xa64/0x1050 [ 137.182693] ? __pfx_kernel_init+0x10/0x10 [ 137.182693] kernel_init+0x24/0x160 [ 137.182693] ? __switch_to_asm+0x3e/0x70 [ 137.182693] ret_from_fork+0x40/0x80 [ 137.182693] ? __pfx_kernel_init+0x10/0x10 [ 137.182693] ret_from_fork_asm+0x1b/0x30 [ 137.182693] </TASK> [ 137.182693] Modules linked in: [ 137.538483] ---[ end trace 0000000000000000 ]--- Fixes: 1b05ece0c9 ("crypto: ccp - During shutdown, check SEV data pointer before using") Cc: stable@vger.kernel.org Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Kim Phillips <kim.phillips@amd.com> Reviewed-by: Liam Merwick <liam.merwick@oracle.com> Acked-by: John Allen <john.allen@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2024-02-23 08:55:08 +01:00
..
allwinner	crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs()	2023-05-17 11:50:20 +02:00
amcc	crypto: crypto4xx - Call dma_unmap_page when done	2023-03-10 09:39:17 +01:00
amlogic	crypto: amlogic - Remove kcalloc without check	2022-12-31 13:14:25 +01:00
axis	crypto: sha - split sha.h into sha1.h and sha2.h	2020-11-20 14:45:33 +11:00
bcm	crypto: bcm - Fix a whole host of kernel-doc misdemeanours	2021-03-26 20:02:35 +11:00
caam	crypto: caam/jr - fix Chacha20 + Poly1305 self test failure	2023-11-20 11:08:22 +01:00
cavium	crypto: nitrox - avoid double free on error path in nitrox_sriov_init()	2022-12-31 13:14:21 +01:00
ccp	crypto: ccp - Fix null pointer dereference in __sev_platform_shutdown_locked	2024-02-23 08:55:08 +01:00
ccree	crypto: ccree - Make cc_debugfs_global_fini() available for module init function	2022-12-31 13:14:24 +01:00
chelsio	crypto: chelsio/chcr - Remove useless MODULE_VERSION	2021-04-22 17:31:31 +10:00
gemini	crypto: gemini - call finalize with bh disabled	2022-04-08 14:23:08 +02:00
hisilicon	crypto: hisilicon/hpre - Fix a erroneous check after snprintf()	2023-11-20 11:08:22 +01:00
inside-secure	crypto: safexcel - Cleanup ring IRQ workqueues on load failure	2023-05-11 23:00:17 +09:00
keembay	crypto: keembay - Remove redundant dev_err calls	2021-04-16 21:16:32 +10:00
marvell	crypto: octeontx2 - Fix cptvf driver cleanup	2024-02-23 08:54:39 +01:00
nx	crypto: nx - fix build warnings when DEBUG_FS is not enabled	2023-07-23 13:47:15 +02:00
qat	crypto: qat - fix deadlock in backlog processing	2023-11-20 11:08:24 +01:00
qce	crypto: qce - fix uaf on qce_skcipher_register_one	2022-01-27 11:03:14 +01:00
rockchip	crypto: rockchip - rework by using crypto_engine	2022-12-31 13:14:22 +01:00
stm32	crypto: stm32/crc32 - fix parsing list of devices	2024-02-23 08:54:39 +01:00
ux500	crypto: ux500 - Fix error return code in hash_hw_final()	2021-05-14 19:07:58 +08:00
virtio	virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()	2024-01-25 14:52:46 -08:00
vmx	crypto: vmx - add missing dependencies	2022-04-08 14:23:08 +02:00
xilinx	crypto: algapi - Remove skbuff.h inclusion	2020-08-20 14:04:28 +10:00
atmel-aes-regs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
atmel-aes.c	crypto: atmel-aes - Reestablish the correct tfm context at dequeue	2022-01-27 11:03:14 +01:00
atmel-authenc.h	crypto: sha - split sha.h into sha1.h and sha2.h	2020-11-20 14:45:33 +11:00
atmel-ecc.c	crypto: atmel-ecc - Struct headers need to start with keyword 'struct'	2021-03-26 20:02:36 +11:00
atmel-i2c.c	crypto: atmel - use the correct print format	2021-04-16 21:16:33 +10:00
atmel-i2c.h	crypto: atmel - Fix -Wunused-const-variable warning	2019-08-30 18:05:31 +10:00
atmel-sha-regs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
atmel-sha.c	crypto: atmel - use the correct print format	2021-04-16 21:16:33 +10:00
atmel-sha204a.c	crypto: atmel-sha204a - Use device-managed registration API	2019-08-02 14:43:59 +10:00
atmel-tdes-regs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
atmel-tdes.c	crypto: atmel - Set OFB's blocksize to 1	2021-07-30 10:58:34 +08:00
exynos-rng.c	crypto: exynos - use devm_platform_ioremap_resource() to simplify code	2019-08-09 15:11:59 +10:00
geode-aes.c	crypto: geode - use DEFINE_SPINLOCK() for spinlock	2021-04-16 21:16:31 +10:00
geode-aes.h	crypto: geode-aes - convert to skcipher API and make thread-safe	2019-10-23 19:46:56 +11:00
hifn_795x.c	crypto: drivers - use semicolons rather than commas to separate statements	2020-10-02 18:02:15 +10:00
img-hash.c	crypto: img-hash - Fix variable dereferenced before check 'hdev->req'	2022-12-31 13:14:26 +01:00
ixp4xx_crypto.c	ARM: SoC changes for 5.14	2021-07-10 09:22:44 -07:00
Kconfig	crypto: sa2ul - Select CRYPTO_DES	2023-05-11 23:00:27 +09:00
Makefile	crypto: sl3516 - Add sl3516 crypto engine	2021-06-11 15:03:29 +08:00
mxs-dcp.c	crypto: mxs-dcp - Fix scatterlist processing	2022-04-08 14:23:05 +02:00
n2_asm.S	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
n2_core.c	crypto: n2 - add missing hash statesize	2023-01-12 11:58:58 +01:00
n2_core.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
omap-aes-gcm.c	crypto: omap-aes - avoid spamming console with self tests	2020-06-04 22:03:39 +10:00
omap-aes.c	crypto: omap-aes - Fix broken pm_runtime_and_get() usage	2022-01-27 11:05:06 +01:00
omap-aes.h	crypto: omap-aes - permit asynchronous skcipher as fallback	2020-07-16 21:49:02 +10:00
omap-crypto.c	crypto: omap - Avoid redundant copy when using truncated sg list	2021-08-21 15:44:53 +08:00
omap-crypto.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
omap-des.c	crypto: omap - Fix inconsistent locking of device lists	2021-08-21 15:44:53 +08:00
omap-sham.c	crypto: omap-sham - Use pm_runtime_resume_and_get() in omap_sham_probe()	2022-12-31 13:14:26 +01:00
padlock-aes.c	crypto: algapi - Remove skbuff.h inclusion	2020-08-20 14:04:28 +10:00
padlock-sha.c	crypto: sha - split sha.h into sha1.h and sha2.h	2020-11-20 14:45:33 +11:00
qcom-rng.c	crypto: qcom-rng - fix infinite loop on requests not multiple of WORD_SZ	2022-05-25 09:57:28 +02:00
s5p-sss.c	crypto: s5p-sss - Add error handling in s5p_aes_probe()	2021-11-18 19:15:53 +01:00
sa2ul.c	crypto: sa2ul - Return crypto_aead_setkey to transfer the error	2024-01-25 14:52:34 -08:00
sa2ul.h	crypto: sa2ul - Add support for AM64	2021-04-22 17:31:30 +10:00
sahara.c	crypto: sahara - do not resize req->src when doing hash operations	2024-01-25 14:52:35 -08:00
talitos.c	crypto: talitos - Fix ctr(aes) on SEC1	2021-01-29 15:57:59 +11:00
talitos.h	crypto: talitos - Work around SEC6 ERRATA (AES-CTR mode data size error)	2021-01-29 15:57:58 +11:00